Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't add custom filter lists as trusted #519

Closed
Roccobot opened this issue Jun 3, 2019 · 3 comments
Closed

Can't add custom filter lists as trusted #519

Roccobot opened this issue Jun 3, 2019 · 3 comments
Assignees
Labels
Milestone

Comments

@Roccobot
Copy link

@Roccobot Roccobot commented Jun 3, 2019

Every time I add my custom filters list by URL, I mark it as 'Trusted' so the advanced rules work as well. But the next time I open the Preferences pane, I see the 'Trusted' mark is gone and in fact the advanced rules aren't working.

Steps to reproduce

  1. Open the Preferences, click the '+' icon (Add filter) on the left.
  2. Clic 'Add custom filter' and provide a URL, click 'Next'.
  3. Make sure that 'Trusted' is enabled, click 'Subscribe'. The list should now appear with a blue ✓ character after its name, meaning it is trusted.
  4. Close the Preferences pane, try to go back to the filters list and check if the mark is still there (and if the advanced rules work). I verified that it disappears and the advanced rules don't work 100% of the time.

↑ Note that I'm using Adguard for Mac with Italian UI so the button labels might be not completely accurate.

Expected behavior

My custom filters list (added via URL) is stored as 'trusted'.

Actual behavior

My custom filters list (added via URL) is stored, but without the 'trusted' attribute, so the advanced filtering rules don't work.

SCREENSHOT

I'm on macOS 10.14.5 (Mojave) and using Adguard for Mac 2.0.4.552 release (CL-1.3.348)

@ameshkov ameshkov added this to the 2.0 milestone Jun 3, 2019
@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Jun 3, 2019

Thanks for reporting it!

@BooBerry

This comment has been minimized.

Copy link

@BooBerry BooBerry commented Jun 3, 2019

I can also confirm this.

@Roccobot

This comment has been minimized.

Copy link
Author

@Roccobot Roccobot commented Jun 14, 2019

Looks like this is solved with build 2.0.6.559, thanks

@Roccobot Roccobot closed this Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.