New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Adguard block ad servers even if HTTPS filtering is turned off #1233
Comments
When HTTPS filtering is turned OFF you should check request during the "outgoing handshake" stage. Create a FilteringContext object with a request URL like "https://" + hostName + "/" and check it against AG filters. |
Sure, but the quality will depend on the filter lists. I suppose that in case of disabled HTTPS filtering it'd be better to import the same filter AG DNS uses: https://github.com/AdguardTeam/AdguardDNS/blob/master/Filters/filter.txt |
@ameshkov could you please check the request above? |
The rule blocking google analytics looks like: The problem with limited https filtering is that we know nothing except request domain name. So we don't know if request is third party or not, therefore it is not blocked. That's why I said that it'd be better to import AG DNS filter. $third-party modifiers are stripped from rules in that filter. |
This rule targets specific file, not the whole domain. Here is the rule to block the whole domain: |
@The-Commissioner in case of the rule The problem is that when https filtering is not enabled, there is no way we can find out which file is requested. The only thing we see is the domain name ( https://github.com/AdguardTeam/AdguardDNS/blob/master/Filters/filter.txt |
Source:
#1228
We should do it for both proxy mode and standard filtering mode. Just examine the SNI extension.
The text was updated successfully, but these errors were encountered: