Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filtering log] $replace rule is shown as applied to images #1392

Closed
Alex-302 opened this issue Nov 21, 2016 · 3 comments

Comments

@Alex-302 Alex-302 added the bug label Nov 21, 2016
@Alex-302 Alex-302 added this to the 6.2 milestone Nov 21, 2016
@confessor-adguard confessor-adguard modified the milestones: 6.1 R2, 6.2 Nov 21, 2016
@Alex-302

This comment has been minimized.

@ameshkov

This comment has been minimized.

Copy link
Member

commented Nov 21, 2016

@confessor-adguard the thing is that $replace rule is stored in the FilteringContext for all requests.
We do not mark requests for which it was actually applied.

So there're two ways of fixing the issue:

  1. Add a "IsReplaceRuleApplied" flag
  2. Clean "FiredReplaceRule" in case if it was not applied.
@ameshkov

This comment has been minimized.

Copy link
Member

commented Nov 21, 2016

We may need to create similar issue in Mac repo as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.