New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with the new filter editor #1547

Closed
Alex-302 opened this Issue Feb 9, 2017 · 15 comments

Comments

Projects
None yet
5 participants
@Alex-302
Member

Alex-302 commented Feb 9, 2017

  1. When user filter is opened in advanced mode, Ctrl+Z clears text field. It is should be a first action, or press Ctrl+Z few times;
  2. Discard changes works without asking to save
  3. Feature request: Esc button should works as Discard changes
  4. Feature request: Add Cut to context menu
  5. When you go back from advanced editor, disabled rules turns on
@theseanl

This comment has been minimized.

Show comment
Hide comment
@theseanl

theseanl Feb 10, 2017

Question: rules in subscribed filters are modifiable which wasn't in previous versions. Is it an intended behavior?

theseanl commented Feb 10, 2017

Question: rules in subscribed filters are modifiable which wasn't in previous versions. Is it an intended behavior?

@confessor-adguard

This comment has been minimized.

Show comment
Hide comment
@confessor-adguard

confessor-adguard Feb 10, 2017

No, this is a bug and will be fixed in the next build.

confessor-adguard commented Feb 10, 2017

No, this is a bug and will be fixed in the next build.

@Alex-302

This comment has been minimized.

Show comment
Hide comment
@Alex-302

Alex-302 Feb 10, 2017

Member
  1. When you go back from advanced editor, disabled rules turns on
Member

Alex-302 commented Feb 10, 2017

  1. When you go back from advanced editor, disabled rules turns on
@confessor-adguard

This comment has been minimized.

Show comment
Hide comment
@confessor-adguard

confessor-adguard commented Feb 10, 2017

1 - 5 fixed.

@ameshkov ameshkov changed the title from Issues in new filter editor to Issues with the new filter editor Feb 10, 2017

@ameshkov ameshkov added this to the 6.2 milestone Feb 10, 2017

@confessor-adguard confessor-adguard self-assigned this Feb 14, 2017

@Alex-302

This comment has been minimized.

Show comment
Hide comment
@Alex-302

Alex-302 Feb 17, 2017

Member

@seanl-adg seanl-adg

Question: rules in subscribed filters are modifiable which wasn't in previous versions. Is it an intended behavior?

@confessor-adguard

No, this is a bug and will be fixed in the next build.

😱 But it is very useful. It is allow to copy part of the rule(for example, domains list or frequently used style) without unnecessary copy-pasting. But there is one drawback - the lines in the filters are not read-only.

Member

Alex-302 commented Feb 17, 2017

@seanl-adg seanl-adg

Question: rules in subscribed filters are modifiable which wasn't in previous versions. Is it an intended behavior?

@confessor-adguard

No, this is a bug and will be fixed in the next build.

😱 But it is very useful. It is allow to copy part of the rule(for example, domains list or frequently used style) without unnecessary copy-pasting. But there is one drawback - the lines in the filters are not read-only.

@Alex-302

This comment has been minimized.

Show comment
Hide comment
@Alex-302

Alex-302 Feb 17, 2017

Member

Also found a bug:
when you edit some rule, and start edit the second rule, an interrupt occurs editing process(each even attempt is aborted).
Video:
https://yadi.sk/d/cN1M-utg3EDXmw

Member

Alex-302 commented Feb 17, 2017

Also found a bug:
when you edit some rule, and start edit the second rule, an interrupt occurs editing process(each even attempt is aborted).
Video:
https://yadi.sk/d/cN1M-utg3EDXmw

@confessor-adguard

This comment has been minimized.

Show comment
Hide comment
@confessor-adguard

confessor-adguard Feb 21, 2017

The bug was fixed.

😱 But it is very useful. It is allow to copy part of the rule(for example, domains list or frequently used style) without unnecessary copy-pasting. But there is one drawback - the lines in the filters are not read-only.

And I found a way to do what you talked about :)

confessor-adguard commented Feb 21, 2017

The bug was fixed.

😱 But it is very useful. It is allow to copy part of the rule(for example, domains list or frequently used style) without unnecessary copy-pasting. But there is one drawback - the lines in the filters are not read-only.

And I found a way to do what you talked about :)

@Alex-302

This comment has been minimized.

Show comment
Hide comment
@Alex-302

Alex-302 Feb 21, 2017

Member

[minor] Switching between filters is slow

Member

Alex-302 commented Feb 21, 2017

[minor] Switching between filters is slow

@Bluscream

This comment has been minimized.

Show comment
Hide comment
@Bluscream

Bluscream Feb 21, 2017

Where is the new filter editor?

Bluscream commented Feb 21, 2017

Where is the new filter editor?

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Feb 21, 2017

Member

@Bluscream inner testing, soon will be available in beta.

Member

ameshkov commented Feb 21, 2017

@Bluscream inner testing, soon will be available in beta.

@Bluscream

This comment has been minimized.

Show comment
Hide comment
@Bluscream

Bluscream commented Feb 21, 2017

Thanks ^^

@Alex-302

This comment has been minimized.

Show comment
Hide comment
@Alex-302

Alex-302 Feb 22, 2017

Member
  1. When user filter is opened in advanced mode, Ctrl+Z clears text field. It is should be a first action, or press Ctrl+Z few times;

the issue is still exists in .1687 build

Member

Alex-302 commented Feb 22, 2017

  1. When user filter is opened in advanced mode, Ctrl+Z clears text field. It is should be a first action, or press Ctrl+Z few times;

the issue is still exists in .1687 build

@confessor-adguard

This comment has been minimized.

Show comment
Hide comment
@confessor-adguard

confessor-adguard Feb 22, 2017

In the case when you open the advanced filter editor for the first time or nothing has changed in it earlier, I guessed?

confessor-adguard commented Feb 22, 2017

In the case when you open the advanced filter editor for the first time or nothing has changed in it earlier, I guessed?

@Alex-302

This comment has been minimized.

Show comment
Hide comment
@Alex-302

Alex-302 Feb 22, 2017

Member

Indeed.

Member

Alex-302 commented Feb 22, 2017

Indeed.

@confessor-adguard

This comment has been minimized.

Show comment
Hide comment
@confessor-adguard

confessor-adguard commented Feb 27, 2017

Fixed.

@ameshkov ameshkov closed this Mar 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment