Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching string in the filter editor or the filtering log is too sluggish #1725

Closed
theseanl opened this issue May 1, 2017 · 1 comment
Closed
Assignees
Labels

Comments

@theseanl
Copy link

@theseanl theseanl commented May 1, 2017

For example, open the filter editor and browse English filter, and then start typing "banner" in the search input field.
Then the UI becomes extremely sluggish, in such a way that when I press "a" key after pressing "b", the letter does not appear in the input field immediately, as if it will display "a" only after finding all matching rules for "b", and so on. Sometimes when I do it fast, the UI crashes (I couldn't make a screenshot, it seems that during the crash printscreen also does not work)
Sometimes this phenomenon occurs in the user filter on my end, which does not contain many rules.

As I remember it wasn't that sluggish on previous versions.

I don't need to see the search result of the current input immediately, I want to see my input immediately. Search result for "bann" would be unnecessary, what is needed is a search result for the full word "banner". So can this search be done in some non-blocking way?

@theseanl theseanl added the question label May 1, 2017
@theseanl theseanl changed the title Searching string in the filter editor or the filtering rule is too sluggish Searching string in the filter editor or the filtering log is too sluggish May 1, 2017
@confessor-adguard

This comment has been minimized.

Copy link

@confessor-adguard confessor-adguard commented May 3, 2017

We will improve the search in the next build.
Also, I am worried about the crash. If this crash occurs again in the next build we will need logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.