Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for subscribing to a filter by clicking a special link on a webpage #1945

Closed
adbuker opened this issue Sep 29, 2017 · 13 comments

Comments

@adbuker
Copy link

commented Sep 29, 2017

Let's implement filter subscription's auto-detection, similar as in case of userscripts. So if we click on subscribe button for any filters (e.g. on the https://adblockplus.org/subscriptions), Adguard invoke "Import filter" dialog with specified filter's link. Also, we need in "Automatically detect filter subscriptions" check-box in the Ad Blocker section.

We should intercept clicks on the page and check the href attribute for abp:subscribe prefix or subscribe.adblockplus.org. Then we should replace it with our own subscribe link and intercept it on the program side.

Also, we should check the "subscriptionUrl" field in filters meta: http://filters.adtidy.org/windows/filters.json

If subscription url matches any of known filters, we'd better enable it.

@adbuker adbuker added this to the 6.3 milestone Sep 29, 2017
@adbuker adbuker self-assigned this Sep 29, 2017
@ameshkov

This comment has been minimized.

Copy link
Member

commented Sep 29, 2017

!!!

@ameshkov ameshkov removed this from the 6.3 milestone Oct 9, 2017
@ameshkov ameshkov added the P2: High label Nov 30, 2017
@ameshkov

This comment has been minimized.

Copy link
Member

commented Nov 30, 2017

Add the same issue for Mac once this one's done

@ameshkov ameshkov added this to the 6.3 milestone Nov 30, 2017
@ameshkov ameshkov changed the title Add support of filterSubscription's autodetection Add support for subscribing to a filter by clicking a special link on a webpage Nov 30, 2017
@adbuker

This comment has been minimized.

Copy link
Author

commented Jan 29, 2018

resolved in adguard-windows/pull-requests/20

@ameshkov

This comment has been minimized.

Copy link
Member

commented Feb 21, 2018

It does not work in the latest nightly build.

Tested on:

@ameshkov ameshkov reopened this Feb 21, 2018
@adbuker

This comment has been minimized.

Copy link
Author

commented Feb 22, 2018

The last bug related to #2126

@ameshkov

This comment has been minimized.

Copy link
Member

commented Feb 22, 2018

One more thing to change. I don't like the way it works now when we for some reason cannot validate a filter list.

  1. Let us have a cache of the validation results (with a short TTL of a minute or so).
  2. We show some extra fields that do not make any sense for a filter: https://uploads.adguard.com/up04_07j12_Windows_7_Enterprise.png
  3. Auto-closing of the helper window brings the focus back to the browser (sometimes). In order to fix this, make sure that AG dialog is on top of other windows (for instance, use some simple hack to bring it up again in a sec)
@adbuker

This comment has been minimized.

Copy link
Author

commented Feb 28, 2018

the addition has been resolved in adguard-windows/pull-requests/43

@Bushido1

This comment has been minimized.

Copy link

commented Apr 18, 2018

Nothing happens if I click on a subscribe link on https://adblockplus.org/subscriptions. I use latest Google Chrome official release.

@adbuker

This comment has been minimized.

Copy link
Author

commented Apr 18, 2018

@Bushido1, please check, that EV filtering isn't disabled. If EV filtering is enabled, please reload the page and clean your browser's cache, and then try again.

@Bushido1

This comment has been minimized.

Copy link

commented Apr 18, 2018

@adbuker EV filtering isn't disabled.

@adbuker

This comment has been minimized.

Copy link
Author

commented Apr 18, 2018

Good, so could you apply second step - reload the page and clean your browser's cache, and then try again

@Bushido1

This comment has been minimized.

Copy link

commented May 10, 2018

@adbuker The second step fixed it. Thank you!

@adbuker

This comment has been minimized.

Copy link
Author

commented May 10, 2018

@Bushido1, great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.