Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some userstyles don't work in AdGuard #1986

Closed
Eugene-Savenko opened this issue Oct 26, 2017 · 5 comments

Comments

@Eugene-Savenko
Copy link
Member

@Eugene-Savenko Eugene-Savenko commented Oct 26, 2017

Following userstyles[extension] doesn't work with AdGuard. Works fine
with Stylish.

https://userstyles.org/styles/userjs/141275/blacktube.user.js
https://userstyles.org/styles/141275/blacktube?utm_campaign=stylish_stylepage

Reported here: 1649743

@theseanl

This comment has been minimized.

Copy link

@theseanl theseanl commented Oct 29, 2017

I can reproduce the issue. This is caused by the position where stylesheets are injected. Currently, we inject styles injected via GM_addStyle to head, but it is causing that among certain competing styles from the userstyle and the youtube's own youtube's style win. We will need to modify GM_addStyle implementation in order to fix it.

@theseanl theseanl self-assigned this Oct 29, 2017
@theseanl

This comment has been minimized.

Copy link

@theseanl theseanl commented Oct 30, 2017

pull-request/92

@ameshkov ameshkov added this to the 6.3 milestone Oct 30, 2017
@ameshkov ameshkov modified the milestones: 6.3, 6.2 Nov 7, 2017
@adbuker adbuker closed this Nov 10, 2017
@zebrum

This comment has been minimized.

Copy link
Member

@zebrum zebrum commented Nov 15, 2017

the second part from forum thread doesn't fixed

@zebrum zebrum reopened this Nov 15, 2017
@ameshkov ameshkov removed this from the 6.2 milestone Nov 30, 2017
@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Nov 30, 2017

We cannot resolve it without full userstyles support:
#1367

Meanwhile, @seanl-adg has made a proper userstyle->userjs converter:
https://adguardteam.github.io/userstyles/converter.html

Code:
https://github.com/AdguardTeam/Userscripts/tree/master/userstyleConverter

We should reuse this code in order to add native userstyles support.

@ameshkov ameshkov closed this Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.