Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inform the user about closed connection to a website with EV certificate #2015

Closed
ameshkov opened this issue Nov 19, 2017 · 3 comments

Comments

@ameshkov
Copy link
Member

commented Nov 19, 2017

We did this in Mac version and also added an option to suppress and filter the website anyway:
AdguardTeam/AdguardForMac#228

Also, we should add "Exclusions" for this feature:
AdguardTeam/AdguardForMac#228 (comment)

We should definitely do the same in AG for Windows, it appears to be really convenient.

@adbuker

This comment has been minimized.

Copy link

commented Feb 9, 2018

resolved in adguard-windows/pull-requests/27

@adbuker adbuker added the nightly label Feb 27, 2018
@ameshkov

This comment has been minimized.

Copy link
Member Author

commented Mar 2, 2018

@adbuker a couple of issues:

  1. This warning is unnecessary as we will implement #1977:
    https://uploads.adguard.com/up04_660lo_Windows_7_Enterprise.png

  2. Do not show the action panel (+/-) when the list is empty:
    https://uploads.adguard.com/up04_r22nn_Windows_7_Enterprise.png

  3. Adding an EV exclusion should also trigger #1977
    Currently, it simply does not work unless I explicitly trigger the network filtering reload.

  4. It is possible to add multiple lines with the same domain. You must simply ignore the duplicates:
    https://uploads.adguard.com/up04_erlfl_Windows_7_Enterprise.png

  5. Deleting items one by one leads to a crash

@adbuker

This comment has been minimized.

Copy link

commented May 3, 2018

2-nd part has been fixed in adguard-windows/pull-requests/94

@vozersky vozersky closed this Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.