Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github discontinued TLS 1.0/1.1 support, we need to address it #2098

Closed
ameshkov opened this issue Feb 1, 2018 · 6 comments

Comments

@ameshkov
Copy link
Member

commented Feb 1, 2018

Here's what it is causing already:
AdguardTeam/PopupBlocker#78

https://githubengineering.com/crypto-deprecation-notice/

We're still using .NET v4 and that's a problem.

The easy solution would be to upgrade to the newer .NET framework version, but that would effectively mean the end of support for Windows XP and that's 2.6% of the website visitors, and that's still a lot.

We should prepare to WinXP EOL in a separate task.
Meanwhile, to address the current issue, we got to use WinHTTP instead of the .NET native client.

You can inspire from this:
https://www.codeproject.com/Articles/66625/A-Fully-Featured-Windows-HTTP-Wrapper-in-C

@sfionov we definitely will need your help with this.

@ameshkov ameshkov added this to the 6.3 milestone Feb 1, 2018

@ameshkov

This comment has been minimized.

Copy link
Member Author

commented Feb 1, 2018

On the other hand, we're almost ready to the WinXP end-of-support:
#1963

@adbuker

This comment has been minimized.

Copy link

commented Feb 1, 2018

as a temporary workaround, we can try the method to force using tls1.2 in the .Net 4.0 (https://stackoverflow.com/questions/33761919/tls-1-2-in-net-framework-4-0), but as explained in the article "It requires .NET 4.5 installed for compilation, but you don't have to target it in the project"

@ameshkov

This comment has been minimized.

Copy link
Member Author

commented Feb 1, 2018

@adbuker could you please test it?

@adbuker

This comment has been minimized.

Copy link

commented Feb 1, 2018

yes, of course

@adbuker

This comment has been minimized.

Copy link

commented Feb 1, 2018

This workaround works pretty good!

@adbuker

This comment has been minimized.

Copy link

commented Feb 1, 2018

resolved in adguard-windows/pull-requests/25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.