Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ExtendedCss to version 1.11 #2152

Closed
ameshkov opened this issue Mar 21, 2018 · 5 comments

Comments

@ameshkov
Copy link
Member

commented Mar 21, 2018

@ameshkov commented on Wed Mar 21 2018

Here is the release:
https://github.com/AdguardTeam/ExtendedCss/releases/tag/1.0.10

What needs to be done:

  1. Add support for the new pseudo-classes added in this version. Check the full list of extended pseudo-classes here: https://github.com/AdguardTeam/ExtendedCss/blob/master/lib/extended-css-selector.js#L28

  2. Start recognizing #?# and #@?# (and also #$?# and #@$?# for style injections) as a marker for an extended rule. Any #?# rule needs to be passed to the ExtendedCss engine. Even if the rule does not contain any special pseudo-class, it must be marked as "extended" anyway. Don't forget to add unit-tests for these rules.

  3. IMPORTANT: ExtendedCss constructor now has two arguments. The new one is propertyFilterIgnoreStyleNodes - a list of stylesheet nodes that should be ignored by the StyleObserver (an object that implements the :properties pseudo-class ). It is crucial to pass a list of custom stylesheets to the constructor.

  4. Don't forget to change highlighting colors in the filters editor.

Check adguard-android/pull-requests/334/overview to see how it's implemented.

@adbuker

This comment has been minimized.

Copy link

commented Mar 26, 2018

resolved in adguard-windows/pull-requests/56

@ameshkov

This comment has been minimized.

Copy link
Member Author

commented Apr 9, 2018

@adbuker we need to return the style protection back

@adbuker

This comment has been minimized.

Copy link

commented Apr 9, 2018

resolved in adguard-windows/pull-requests/66

@ameshkov ameshkov changed the title Update ExtendedCss to version 1.10 Update ExtendedCss to version 1.11 Apr 24, 2018
@ameshkov

This comment has been minimized.

Copy link
Member Author

commented Apr 24, 2018

Use the new version from the content script repo

@adbuker

This comment has been minimized.

Copy link

commented Apr 27, 2018

resolved in adguard-windows/pull-requests/87

@vozersky vozersky closed this Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.