Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update Traditional Chinese translations for filters. #2245

Closed
lancelot-moon opened this issue Jun 10, 2018 · 4 comments

Comments

@lancelot-moon
Copy link

commented Jun 10, 2018

  1. In the past, AdGuard team wrongly used Simplified Chinese translations in Traditional Chinese interface.
    Taiwanese people learn Traditional Chinese characters from the childhood and don't understand every Simplified Chinese character.
    If someone wants to have Simplified Chinese interface, he goes to choose Simplified Chinese language.
    Since we choose Traditional Chinese language, we dislike to read Simplified Chinese characters.
    It's about the problem of esteem.
    For example, will you use Ukrainian translations in Russian language file if Russian translations are deficient?

In your opinion, the logic of language sequence for Traditional Chinese app interface is Traditional Chinese -> Simplified Chinese (if there is no Traditional Chinese translations) -> English (if there are no Traditional & Simplified Chinese translations), which is wrong for Taiwanese people.

Traditional Chinese -> English (if there is no Traditional Chinese translations).

Please remove Simplified Chinese from the logic.

In AG for Android / iOS, the mistakes are fixed.
AdguardTeam/AdguardForAndroid#1762

But you still don't fix it in AG for Windows.
They're Simplified Chinese, not Traditional Chinese.

Screenshot:

image


  1. "English filter (英文過濾器)" was renamed to "AdGuard Base filter (AdGuard 基本過濾器)".
    You should also update the translations of filters from oneskyapp.

Thanks.

@ameshkov

This comment has been minimized.

Copy link
Member

commented Jun 10, 2018

@ameshkov

This comment has been minimized.

Copy link
Member

commented Jun 10, 2018

@adbuker check that we use proper locale when showing filters subscriptions

@ameshkov ameshkov added this to the 6.3 milestone Jun 10, 2018
@ameshkov

This comment has been minimized.

Copy link
Member

commented Jun 13, 2018

@adbuker

This comment has been minimized.

Copy link

commented Jun 13, 2018

resolved in adguard-windows/pull-requests/126

@vozersky vozersky closed this Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.