Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avast Free prevents AdGuard from suppressing QUIC #2310

Closed
dnmTX opened this issue Aug 24, 2018 · 28 comments
Closed

Avast Free prevents AdGuard from suppressing QUIC #2310

dnmTX opened this issue Aug 24, 2018 · 28 comments
Assignees
Milestone

Comments

@dnmTX
Copy link

@dnmTX dnmTX commented Aug 24, 2018

Steps to reproduce

  1. download Avast Antivirus(free edition).Go to anything GOOGLE or YOUTUBE

Expected behavior

Ads and anything custom filtered to be blocked

Actual behavior

Let's start with google.com(not filtered),google searches start showing ads,youtube is completely unfiltered.
I even opened AdGuard's filtering log and then opened Youtube,the log was EMPTY.
Avast fucked this one up big times and there is no point to even raise the issue in their forum.
Those morons there just gonna deny it or not respond.
By disabling Avast,AdGuard work as intended on all pages.
Big hopes here that you guys can fix it due to no good lite alternatives for Antivirus right now.
Thank you.

Your environment

  • Environment name and version (e.g. Chrome 59):
    Slimjet Version 19.0.9.0 (based on Chromium 66.0.3359.117) (Official Build) (64-bit)
  • Operating system and version (e.g. Windows 10, v.1703, build 15063.413)
    Windows 10, v.1607, build 14393.2430
@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Aug 24, 2018

That's unusual, this is the first complaint of that sort so far. We'll try to reproduce it first

@dnmTX

This comment has been minimized.

Copy link
Author

@dnmTX dnmTX commented Aug 24, 2018

@ameshkov it's been like this for at least 10 days,i just couldn't figure it out where the problem is coming from.Also there is not even one complaint about this in their forum which scares me a lot and makes me think that they will continue doing it.They sold their soul to the devil(GOOGLE) so i wouldn't expect anything less.Let me know if i can help with anything and.....KEEP UP THE GOOD WORK.THANK YOU !!!!

@zebrum

This comment has been minimized.

Copy link
Member

@zebrum zebrum commented Aug 24, 2018

@dnmTX so far I can't reproduce the issue.

  1. What AdGuard version do you use?
  2. Is Avast app added to filtered apps in AdGuard settings? If so, please make a screenshot
  3. Please collect debug logs (right-click on the AdGuard icon in the system tray, then go to Advanced > Logging level > Debug) and send it by email to: devteam at adguad.com
@dnmTX

This comment has been minimized.

Copy link
Author

@dnmTX dnmTX commented Aug 24, 2018

@zebrum :
Version 6.3.1399.4073

Is Avast app added to filtered apps in AdGuard settings? If so, please make a screenshot

It's not added(does it need to be?).If it does,i need to know how cause i couldn't find it listed in app list.

Please collect debug logs (right-click on the AdGuard icon in the system tray, then go to Advanced > Logging level > Debug) and send it by email to: devteam at adguad.com

Will do.Do you need me to do it while i'm browsing Youtube or it doesn't matter?

adguard

Regarding the screenshot:
IE is uninstalled
No Modern UI app's here,using Windows Enterprise 1607 LTSB version

P.S. Debug Log sent.

@dnmTX

This comment has been minimized.

Copy link
Author

@dnmTX dnmTX commented Aug 25, 2018

UPDATE:
Ok...this is what i discovered so far.Avast somehow was interfering(blocking) with the WFP Network Driver.
By disabling it all went back to normal,youtube is completely filtered as well as google etc.My question is do i need the WFP driver enabled,is it better(faster) with it?
On my system i don't have any Modern Windows UI app's,Windows Store and so on and the description of it stating that it's suppose to filter the modern UI app's.
If there isn't a downside for me when it's disabled i'd rather keep it this way for now cause by the look of it you guys can't even reproduce the issue so my guess is it will take a while until it gets fixed.

@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Aug 27, 2018

@dnmTX is it possible to somehow export the Avast settings?

Regarding the TDI driver, it's an older API which is generally more stable.

@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Aug 27, 2018

@zebrum my idea is that Avast messes with AdGuard blocking QUIC.

Check if you see anything on this tab when Avast and AG work alongside: chrome://net-internals/#quic

@dnmTX

This comment has been minimized.

Copy link
Author

@dnmTX dnmTX commented Aug 27, 2018

@ameshkov oh yeah...i got back ups(not sure how this will help you though)..I can also do the same for the adgnetworktdidrv.sys so you can see if it's been hacked or something.Let me know.

@dnmTX

This comment has been minimized.

Copy link
Author

@dnmTX dnmTX commented Aug 27, 2018

This is captured events but at the present i'm using the TDI driver
events

@dnmTX

This comment has been minimized.

Copy link
Author

@dnmTX dnmTX commented Aug 27, 2018

@ameshkov there you go,the Avast settings:

free_av_18.6.2349_2018-8-27_2-44-5.zip

...and the adgnetworktdidrv.sys just in case:

adgnetworktdidrv.zip

@Mo-norn

This comment has been minimized.

Copy link

@Mo-norn Mo-norn commented Aug 27, 2018

I am using Avast free, Whale browser(Chromium Engine 65) and AdGuard does not block YOUTUBE ads properly.
It seems to be a problem of avast web shield.
disabling avast web shield, AdGuard will block ads properly.

Your environment

Whale Version 1.3.51.7 (Chromium Engine 65)
Windows 10, v.1803 build 17134.228

@ameshkov ameshkov added this to the 6.4 milestone Aug 27, 2018
@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Aug 27, 2018

This is captured events but at the present i'm using the TDI driver

Could you please switch to the WFP driver and check it?

  1. Enable the WFP driver (reboot is not necessary)
  2. Reproduce the issue
  3. Open chrome://net-internals/#quic: https://uploads.adguard.com/up04_wn2a0_chromenet-internalsquic.png
  4. Check if you see active QUIC sessions there
@dnmTX

This comment has been minimized.

Copy link
Author

@dnmTX dnmTX commented Aug 27, 2018

@ameshkov, yep,as you suspected it has something to do with QUIC. Screenshots are with ACTIVE
WFP Network Driver:

google.com:
google-quic

playing some video from youtube.com:
youtube-quic

P.S. Wondering if disabling the QUIC protocol from chrome://flags would fix that issue all along,or it's needed?
EDIT: When disabled pages kind of loading a bit slower so i guess it's needed

@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Aug 28, 2018

This must be the same issue as with Kaspersky (it messes with us blocking QUIC).

@northis the solution is the same, suppress UDP traffic to ports 80 and 443 if Avast's WFP driver is detected.

@dnmTX please bear with us, we'll soon send you a test build with this issue resolved and we'd be glad if you can test and verify it on your side.

@ameshkov ameshkov changed the title [important] Avast Free is blocking AdGuard to filter certain pages Avast Free free prevents AdGuard from suppressing QUIC Aug 28, 2018
@dnmTX

This comment has been minimized.

Copy link
Author

@dnmTX dnmTX commented Aug 28, 2018

@dnmTX please bear with us, we'll soon send you a test build with this issue resolved and we'd be glad if you can test and verify it on your side.

I'd be happy to.No rush though,TDI filter is working just fine here 😉

@northis

This comment has been minimized.

Copy link
Member

@northis northis commented Aug 29, 2018

@dnmTX please test this build on your side. Thank you.

@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Aug 29, 2018

@dnmTX you'll need to enable QUIC back in the browser settings in order to properly reproduce this issue.

Please note, that this build is newer than the current stable version so you might want to backup your current settings if you want to downgrade to the stable version after testing.

@dnmTX

This comment has been minimized.

Copy link
Author

@dnmTX dnmTX commented Aug 29, 2018

Well...reporting back.Sadly it does not work 🙁.No difference at all.Every page is filtered fine but Google and Youtube.QUIC showing active sessions as well like from the screenshot above.I just send you guys debug log from the 1551 Nightly in case you needed.Switching back to stable build,if you need my assistance with other builds let me know,don't mind testing them.Big hopes that you'll be able to find solution soon.

@dnmTX

This comment has been minimized.

Copy link
Author

@dnmTX dnmTX commented Aug 29, 2018

@ameshkov uploaded the debug log from the nightly in my google drive,here is the link just in case there is a problem getting it from the e-mail:
https://drive.google.com/file/d/1FxmfXfE9ft9JQZxO02Q_zOMZ4hbFvfxV/view?usp=sharing

@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Aug 29, 2018

We finally managed to reproduce the issue on our side, thank you!

@dnmTX dnmTX changed the title Avast Free free prevents AdGuard from suppressing QUIC Avast Free prevents AdGuard from suppressing QUIC Sep 2, 2018
@adbuker

This comment has been minimized.

Copy link

@adbuker adbuker commented Sep 6, 2018

@dnmTX, we've fixed this issue, please try this build - https://uploads.adguard.com/Setup_6.4.1580_nightly.exe.
Note, that after the installing this build the reboot is required. Please, let us know about the result after the testing this build.

@adbuker

This comment has been minimized.

Copy link

@adbuker adbuker commented Sep 6, 2018

the issue is fixed along with the #2308

@dnmTX

This comment has been minimized.

Copy link
Author

@dnmTX dnmTX commented Sep 6, 2018

@adbuker @ameshkov REPORTING SUCCESS 😊.
All working as it should.Tested google and youtube several times to make sure(avast is active).
Good job guys.Thank you.
My question is is it better to stay with the nightly or go back to stable release(which i prefer).Any chance you guys release some small update on the stable release just to fix this issue or we have to wait till 6.4 release?

@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Sep 6, 2018

@dnmTX v6.4 is supposed to be a minor hotfix update and it's not too long till it's ready to go stable.

@dnmTX

This comment has been minimized.

Copy link
Author

@dnmTX dnmTX commented Sep 6, 2018

@ameshkov ok then,i'll go back to stable for now,TDI filter is still working there and will wait for the 6.4 release. Let's hope that Avast won't do some fuck up again(one can only hope).I'll keep you posted.
I guess you can close this for now if you want until it has to be reopen.

P.S. @Mo-norn you mind testing the nightly on your end just so we can get at least one more confirmation with newer Windows version?

@Mo-norn

This comment has been minimized.

Copy link

@Mo-norn Mo-norn commented Sep 26, 2018

Adguard BETA 6.4.1639.4553 Works normally. Thank you.

@dnmTX

This comment has been minimized.

Copy link
Author

@dnmTX dnmTX commented Sep 26, 2018

@ameshkov how long until the official release?

@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Sep 26, 2018

@dnmTX nothing left on this milestone so it's coming really soon. We a week or so on running all the compatibility tests (with AVs mostly), and we're good to go.

@zebrum zebrum closed this Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.