Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude app from filtering by entering full path excluding all apps with the same executable name #2453

Closed
BooBerry opened this issue Mar 2, 2019 · 2 comments

Comments

Projects
None yet
4 participants
@BooBerry
Copy link

commented Mar 2, 2019

AG for Win 7 nightly, completely clean/fresh install.

Should be kinda self-explanatory. I have two portable browsers that I always add to the exclude app list. However, if I add these apps in AG for Win 7, all apps with the same executable name are also excluded. Let's say I add this path/executable for portable Chromium to the exclude app list...

C:\Chromium\bin\chrome.exe

The exclusions seemingly applies to all apps with the same chrome.exe executable name, including Google Chrome that's installed in a different location. Now, for the next example if I add these paths/executables for portable Firefox to the exclude app list...

C:\FirefoxPortable\App\Firefox\firefox.exe;C:\FirefoxPortable\App\firefox64\firefox.exe

Again, the exclusions are seemingly not just applying to those portable Firefox executables, but also all apps with the same firefox.exe executable name installed in a different location as well.

Expected behavior

Exclude app from filtering by entering full path should only exclude that specific app in that specific path (e.g. the previous behaviour found in AG for Win 6).

Actual behavior

Exclude app from filtering by entering full path excludes all apps with the same executable name, seemingly ignoring the full path.

@ameshkov ameshkov added this to the 7.0 milestone Mar 4, 2019

@adbuker

This comment has been minimized.

Copy link

commented Mar 14, 2019

resolved in /core/pull-requests/1118 along with adguard-windows/pull-requests/338

@adbuker

This comment has been minimized.

Copy link

commented Mar 15, 2019

How to test:
Step 1

  1. Install ff and start it
  2. Install ff developer edition and start it
  3. Install TOR browser and start it

Expected behaviour:

  1. ff and ff dev edition are filtered (both http and https traffic), and TOR's https traffic is not filtered
  2. In the filtered app's section both TOR apps (browser and TOR itself) have "https filtered" disabled option

Step 2

  1. Add ff dev edition to the filtered exclusion (via "advanced settings")

Expected behaviour:

  1. ff dev edition is not filtered
  2. ff still filtered (both http and https traffic)

@zzebrum zzebrum closed this May 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.