New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adguard GUI unnecessarily raising Windows platform timer resolution #2734
Comments
Thanks for reporting it! As I understand, the only way to fix this is to call We'll need to check if that causes any issues with it. |
The problem is you can only close these particular requests using It could be that you are not even doing such calls within your own code. In the linked blog article, it is mentioned that WPF, or to be more precise As far as I understood, if it's not your code which is calling Could it be that you are unintentionally still rendering parts of your UI, even if it's minimized? |
@tox1c90 We will try to solve the problem. |
Resolved in |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Although the changelog states that it was fixed "[Fixed] AdGuard GUI unnecessarily raises Windows platform timer resolution #2734", it's behaving exactly the same as before on my PCs. That's a bit strange.... |
@tox1c90 Perhaps, we've taken in account not all the cases - issue is really reproduced on main window. We'll fix it of course. But the rest of the cases are ok. |
Resolved in |
I am sorry, I really dont want to annoy you again with this issue, but would you mind setting it to 156250 instead, because this is the default value of Windows 8 and 10 upwards. 156000 was the Windows 7 default. The difference is quite tiny, but calling 156000 still results in an energy report warning. |
@tox1c90 No problem, we will change it. |
Resolved in |
Steps to reproduce
Expected behavior
It is common for GUIs using WPF or for example Chromium to raise platform timer resolution when it's needed, so when the Adguard GUI is shown and not minimized, this can be the normal behavior. But when it's minimized to tray, this should be stopped and timer resolution should be reverted to it's default value, to allow the CPU to reach it's lowest power states.
Actual behavior
Once Adguard.exe causes the platform timer resolution to be raised, it stays there until the process is terminated, even when Adguard GUI is not rendered anymore but minimized to tray.
Background information on why this is bad: https://randomascii.wordpress.com/2013/07/08/windows-timer-resolution-megawatts-wasted/
Short version: Much lower CPU C state usage because of raised timer resolution, thus higher idle power consumption, very bad for battery life
On my PC the CPU core C7 state usage is dropping from ~95% to ~86% just after Adguard increased timer resolution.
Screenshot:
Customer ID
Your environment
The text was updated successfully, but these errors were encountered: