Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adguard does not filter pages with Content-Type:application/xhtml #571

Closed
Alex-302 opened this issue Dec 9, 2015 · 4 comments

Comments

@Alex-302
Copy link
Member

commented Dec 9, 2015

AdguardTeam/AdguardFilters#1028

Example:
us.battle.net

@Alex-302 Alex-302 added the bug label Dec 9, 2015

@ameshkov ameshkov added this to the 6.0 release milestone Dec 30, 2015

@confessor-adguard

This comment has been minimized.

Copy link

commented Jan 14, 2016

Known issue.

Content-Type:application/xhtml+xml;charset=UTF-8

@ameshkov ameshkov changed the title us.battle.net - Adguard doesn't injects to the page Adguard does not process pages with Content-Type:application/xhtml Jan 17, 2016

@ameshkov ameshkov changed the title Adguard does not process pages with Content-Type:application/xhtml Adguard does not filter pages with Content-Type:application/xhtml Jan 17, 2016

@confessor-adguard

This comment has been minimized.

Copy link

commented Jan 19, 2016

This issue migrates into 6.1 milestone.

We have some compatibility problems now:

Uncaught SyntaxError: Failed to set the 'innerHTML' property on 'Element': The provided markup is invalid XML, and therefore cannot be inserted into an XML document.
    v.extend.clean @ Adguard Assistant?rand=635888115703473421:345
    v.buildFragment @ Adguard Assistant?rand=635888115703473421:342
    v.fn.extend.domManip @ Adguard Assistant?rand=635888115703473421:340
    a.fn.extend.domManip @ Adguard Assistant?rand=635888115703473421:392
    v.fn.extend.append @ Adguard Assistant?rand=635888115703473421:335
    loadTemplates @ Adguard Assistant?rand=635888115703473421:182
    loadAssistant @ Adguard Assistant?rand=635888115703473421:182
    (anonymous function) @ Adguard Assistant?rand=635888115703473421:191

P.S. Don't forget to use CDATA for scripts on application/xhtml pages.

@confessor-adguard confessor-adguard modified the milestones: 6.1, 6.0 release Jan 19, 2016

@ameshkov ameshkov modified the milestone: 6.1 Apr 20, 2016

@ameshkov

This comment has been minimized.

Copy link
Member

commented Apr 21, 2016

Resolved in Android version (we have no assistant there anyway):
AdguardTeam/AdguardForAndroid#477

Useful documentation:
https://developer.mozilla.org/en-US/docs/Archive/Web/Writing_JavaScript_for_HTML

@ameshkov ameshkov modified the milestones: 6.1 R2, 6.1 Jul 27, 2016

@confessor-adguard

This comment has been minimized.

Copy link

commented Sep 15, 2016

Important:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.