Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not uninstalls WFP driver on Win 10 x64 #854

Closed
CHEF-KOCH opened this issue Feb 9, 2016 · 9 comments
Assignees
Labels
Milestone

Comments

@CHEF-KOCH
Copy link

@CHEF-KOCH CHEF-KOCH commented Feb 9, 2016

AdGuard Version: 6.0.189.984
Win: 10 Entp. LTSB N x64

The driver under /Windows/system32/drivers are not uninstalled or respected by current uninstaller, which means it not get's removed or you get any notice to reboot your machine (because driver changes).

Imho there should be additional uninstall checks to ensure it gets cleaned in case someone want to just update AdGuard and want to start with fresh settings and of course drivers (I'm unsure if it get's replaced with newer version on fresh installation).

@ameshkov ameshkov added this to the 6.0 R2 milestone Feb 9, 2016
@ameshkov ameshkov added the installer label Feb 9, 2016
@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Feb 9, 2016

We once fixed that issue and tested it, it's weird that it's here again.

@confessor-adguard please check this, something definitely went wrong.

@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Feb 9, 2016

(I'm unsure if it get's replaced with newer version on fresh installation).

It will if the driver version changes, but anyway, driver must be uninstalled.

@CHEF-KOCH One more question: have you checked "Remove along with settings" option while doing the uninstall?

@CHEF-KOCH

This comment has been minimized.

Copy link
Author

@CHEF-KOCH CHEF-KOCH commented Feb 10, 2016

Yes, that option was checked but I must admit the last time I checked wasn't with the mentioned AdGuard Version, it was the 'final' version that was released another day before, but from what I could read nothing was mentioned in the latest changelog about this so I think this is/was still an issue.

@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Feb 10, 2016

I thought that it was fixed two weeks ago along with #771.

@CHEF-KOCH

This comment has been minimized.

Copy link
Author

@CHEF-KOCH CHEF-KOCH commented Feb 10, 2016

Well, maybe your link it's wrong but we not talking about the certificate (that is now fixed - thanks) but the driver is a bit different, since there is also no popup to reboot (because possible driver related changes or network changes).

What I also realized is that if you checked the 'remove along with settings' option, it not reset's the driver status, I'm talking about the WPF checkmark within options, I know several versions before the WPF driver wasn't checked by default (for me). Or is this also fixed by detecting the OS? I'm asking because I'm sure this wasn't checked by default.

@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Feb 10, 2016

Well, maybe your link it's wrong but we not talking about the certificate

I asked to check the driver also (just didn't commented the issue).

What I also realized is that if you checked the 'remove along with settings' option, it not reset's the driver status, I'm talking about the WPF checkmark within options

Well, this could be the issue, the driver file could be left by one of the previous versions. WPF option value is detected on install and depends on your OS and AV used. We have changed it several times since alpha version.

Anyway, the driver should not be registered even if the file still exists.

You can check it in cmd:

sc query adgnetworkwfpdrv
@CHEF-KOCH

This comment has been minimized.

Copy link
Author

@CHEF-KOCH CHEF-KOCH commented Feb 10, 2016

I asked to check the driver also (just didn't commented the issue).

Ok: 👍

Okay, I removed now the driver, registry leftovers and everything I could find on my hdd. So I will re-check this to ensure it's not on my end.

@CHEF-KOCH

This comment has been minimized.

Copy link
Author

@CHEF-KOCH CHEF-KOCH commented Feb 22, 2016

Fixed with R2 & Uninstaller Util.

I also tested with a fresh installation and it seems fixed or not present anymore.

@CHEF-KOCH CHEF-KOCH closed this Feb 22, 2016
@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Feb 22, 2016

Nice, thank you for testing it!

@suhan3z suhan3z changed the title Not uninstalls WPF driver on Win 10 x64 Not uninstalls WFP driver on Win 10 x64 Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.