Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Content Blockers State" screen to the advanced settings #1105

Closed
ameshkov opened this issue Jul 3, 2019 · 3 comments
Closed

Add "Content Blockers State" screen to the advanced settings #1105

ameshkov opened this issue Jul 3, 2019 · 3 comments
Assignees
Milestone

Comments

@ameshkov
Copy link
Member

@ameshkov ameshkov commented Jul 3, 2019

This screen should be somewhere under "Advanced" settings, and it's purely informational.

Here's what we should show there:

  • Content blocker name
  • Content blocker state (enabled or disabled)
  • Filter lists included into this content blocker
  • Content blocker rules state (everything is okay, rules loading is in progress, an error occurred while loading the rules)
  • The number of rules loaded into the content blocker
  • If the number of rules is more than 50k, we should show how many rules were ignored
@AlikhanAliev

This comment has been minimized.

Copy link

@AlikhanAliev AlikhanAliev commented Jul 9, 2019

@IvanIin

This comment has been minimized.

Copy link
Contributor

@IvanIin IvanIin commented Aug 5, 2019

Incorrect number of enabled and disabled rules are showed when you enable a lot of content blockers.
Screenshot 2019-08-05 at 10 20 43

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Aug 5, 2019

Moved back to in progress

@zzebrum zzebrum closed this Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.