Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify why exactly "protection is disabled" on the main screen #1106

Closed
ameshkov opened this issue Jul 3, 2019 · 2 comments
Closed

Specify why exactly "protection is disabled" on the main screen #1106

ameshkov opened this issue Jul 3, 2019 · 2 comments
Assignees
Milestone

Comments

@ameshkov
Copy link
Member

@ameshkov ameshkov commented Jul 3, 2019

Currently, even if a single one of the content blockers are disabled, we will show "protection is disabled" on the main screen.

We should show short explanation (instead of showing the filters state): One or many of AdGuard's content blockers are disabled in Safari settings. Please, enable all of them..

@AlikhanAliev ideally, I'd like to show which exact content blockers are disabled.

@ameshkov ameshkov added this to the 3.1 milestone Jul 3, 2019
@ameshkov ameshkov added the UI label Jul 4, 2019
@worldsdream

This comment has been minimized.

Copy link

@worldsdream worldsdream commented Jul 14, 2019

Yes please. A must!

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Aug 12, 2019

Let's have three possible statuses:

  • Protection is disabled -- all content blockers are disabled
  • Some content blockers are disabled -- self-explanatory
  • Protection is enabled
adguard pushed a commit that referenced this issue Aug 15, 2019
* commit '1d32dabdcc76e518946080af7cb917c3c7d9a5be':
  string fixed
  ContentBlockersScreen improvements
@zzebrum zzebrum closed this Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.