Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate user filter / whitelist rules properly #1174

Closed
ameshkov opened this issue Aug 12, 2019 · 0 comments
Closed

Validate user filter / whitelist rules properly #1174

ameshkov opened this issue Aug 12, 2019 · 0 comments
Assignees
Milestone

Comments

@ameshkov
Copy link
Member

@ameshkov ameshkov commented Aug 12, 2019

Currently, we are waiting until the user filter or whitelist are loaded to the Safari content blocker.

Here's what we should do instead:

  1. Add user filter rules validation (we accept comments, valid basic and cosmetic rules).
  2. Add whitelist rules validation (domain name).
  3. Do not wait for the user filter / whitelist will be loaded to the Safari content blocker.
@ameshkov ameshkov added this to the 3.1 milestone Aug 12, 2019
adguard pushed a commit that referenced this issue Aug 23, 2019
…aster

* commit 'd83b0e1caad36d382cf0285ab0133cb1b3f983b5':
  add comment
  generate strings
  add clear button to user filter in edit mode
  fix build tests
  Validate user filter / whitelist rules properly #1174
@zzebrum zzebrum closed this Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.