Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the way a whitelist rule is added to the content blocker when you unblock via the Safari action extension #1218

Closed
ameshkov opened this issue Sep 2, 2019 · 0 comments
Assignees
Milestone

Comments

@ameshkov
Copy link
Member

@ameshkov ameshkov commented Sep 2, 2019

Instead of the current naive algorithm, we should parse the JSON, and add a new rule at the end of the content blocking rules array (keeping the length below 50k).

@ameshkov ameshkov added this to the 3.1 milestone Sep 2, 2019
adguard pushed a commit that referenced this issue Sep 13, 2019
adguard pushed a commit that referenced this issue Sep 13, 2019
…218 to master

* commit '21d87a6443ae66f2ef0e6aa04efb77513733aee8':
  fix punycode
  - crash fix - punycode and lowercase domains
  Change the way a whitelist rule is added to the content blocker when you unblock via the Safari action extension #1218 #1218
@zzebrum zzebrum closed this Sep 23, 2019
adguard pushed a commit that referenced this issue Dec 6, 2019
* commit '6b3739b6f5f2a27c9d4d7367beaecfcad584ba59': (72 commits)
  skipci: Automatic version increment
  update translations
  Сrash after trying to add a site to whitelist using the extension assistant #1249 #1249
  skipci: Automatic version increment
  skipci: Automatic version increment
  update translations
  Filter update issue/UI bug #1041 #1041
  removed security section from cloudflare dns
  skipci: Automatic version increment
  changed migration logic
  skipci: Automatic version increment
  fix punycode
  - crash fix - punycode and lowercase domains
  skipci: Automatic version increment
  Change the way a whitelist rule is added to the content blocker when you unblock via the Safari action extension #1218 #1218
  docs: ✏️ upd readme
  fix: 🐛 Blocked AAAA requests are not reflected in the log
  skipci: Automatic version increment
  Adguard: -[ACObject propertyNames] + 208
  maybe fixed  Adguard: -[FMDatabase executeQuery:withArgumentsInArray:orDictionary:orVAList:] + 900
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.