Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPN icon not hidden in iOS 13 #1246

Open
akmLaVx opened this issue Sep 15, 2019 · 4 comments
Assignees
Labels
Milestone

Comments

@akmLaVx
Copy link

@akmLaVx akmLaVx commented Sep 15, 2019

Issue Details

Since updating to iOS 13, VPN icon is no longer hidden even when the corresponding option is selected in the settings.

  • AdGuard version:
    -3.0.2.157
  • Device model and storage size:
    • Unspecified iPhone
  • Operating system and version:
  • iOS 13.0

Expected Behavior

VPN icon should be removed when AdGuard is set to not display it

Actual Behavior

VPN icon is displayed regardless of AdGuard settings

Screenshots

Screenshot:

image0

Additional Information

Helpdesk ID: 1524752

@ameshkov ameshkov added this to the 3.1_patch milestone Sep 19, 2019
adguard pushed a commit that referenced this issue Sep 20, 2019
adguard pushed a commit that referenced this issue Sep 20, 2019
…aster

* commit '031d2fc8e5bc93d55a69737d404e0bd7e2a214d9':
  VPN icon not hidden in iOS 13 #1246 #1246
@zzebrum zzebrum closed this Oct 2, 2019
@Eugene-Savenko

This comment has been minimized.

Copy link
Member

@Eugene-Savenko Eugene-Savenko commented Oct 7, 2019

The OP states that it still does not hide the VPN icon properly after the recent patch.

screenshots

image

image

@Eugene-Savenko Eugene-Savenko reopened this Oct 7, 2019
@ameshkov ameshkov modified the milestones: 3.1_patch, 3.1_patch2 Oct 7, 2019
@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Oct 7, 2019

Reopened and re-assigned to v3.1 patch2

@iDjay

This comment has been minimized.

Copy link

@iDjay iDjay commented Oct 14, 2019

Would like to see a split tunnel without VPN icon option :)

Sent with GitHawk

@IvanIin

This comment has been minimized.

Copy link
Contributor

@IvanIin IvanIin commented Oct 17, 2019

DnsCloak works different way. It does not set ipv4Settings and ipv6Settings. Sets localhost as DNS resolver address. And listen on the 53rd port dns requests. With this configuration, tunnel works in a split mode without vpn icon. To show VPN icons, DnsCloak sets fake ipv4Settings and ipv6Settings.
We can use the same scheme for split tunnel mode. For full tunnel mode, we cannot leave ipv4Settings and ipv6Settings settings empty.
This is a pretty big rework. Let's think and possibly implement the mixed scheme in 3.2

@IvanIin IvanIin modified the milestones: 3.1_patch2, 3.2 Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.