Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$popup rules and iframes #682

Closed
ameshkov opened this issue Jan 24, 2019 · 2 comments
Closed

$popup rules and iframes #682

ameshkov opened this issue Jan 24, 2019 · 2 comments
Assignees
Labels
Milestone

Comments

@ameshkov
Copy link
Member

@ameshkov ameshkov commented Jan 24, 2019

Fixing this one requires some blocking page changes. The idea is to detect that we're inside an iframe and the rule has $popup modifier, and bypass this request in this case.

||example.org^$popup

@ameshkov ameshkov added this to the v1.3 milestone Jan 24, 2019
@ameshkov ameshkov added the JS label Apr 2, 2019
@sfionov

This comment has been minimized.

Copy link
Member

@sfionov sfionov commented Jun 14, 2019

@timirila1 I've created test page for ||example.org^$popup:
https://sfionov.github.io/web/test.html
Here are two issues:

  1. iframe still blocked
  2. popup is blocked, but URL is whitelisted for 5 seconds anyway, next popup will succeed.
@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Oct 9, 2019

Actually, this creates more problems than it solves. Let's make $popup rules simply block frames.

@ameshkov ameshkov changed the title $popup rules shouldn't block iframes $popup rules and iframes Oct 9, 2019
@ameshkov ameshkov modified the milestones: v1.6, v1.5 Oct 9, 2019
@zzebrum zzebrum closed this Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.