In the current implementation $genericblock is basically the same as $document, i.e. it disables filtering completely.
This implementation can be improved if we change the way the list is ordered.
Here's how the rules should be ordered:
- Generic
css-display-none rules
$generichide ignore-previous-rules
- Generic url blocking rules
$genericblock ignore-previous-rules
- Domain-specific
css-display-none rules
$elemhide ignore-previous-rules
- Domain-specific url blocking rules
$urlblock ignore-previous-rules
In addition to that $genericblock rules' resource-types should be limited and exclude document. In this case it will not cover cosmetic rules.
Actually, when we add ignore-following-rules support, it will be easier to solve it.
In the current implementation
$genericblockis basically the same as$document, i.e. it disables filtering completely.This implementation can be improved if we change the way the list is ordered.
Here's how the rules should be ordered:
css-display-nonerules$generichideignore-previous-rules$genericblockignore-previous-rulescss-display-none rules$elemhideignore-previous-rules$urlblockignore-previous-rulesIn addition to that
$genericblockrules'resource-typesshould be limited and excludedocument. In this case it will not cover cosmetic rules.Actually, when we add ignore-following-rules support, it will be easier to solve it.