Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 incompatibility #19

Closed
AdmiralenOla opened this issue Jun 8, 2016 · 7 comments
Closed

Python3 incompatibility #19

AdmiralenOla opened this issue Jun 8, 2016 · 7 comments
Labels

Comments

@AdmiralenOla
Copy link
Owner

Scoary currently doesn't work with python3. It seems to freeze and eat up memory when trying to populate the quadtree with pairwise hamming distances.

@mgalardini
Copy link
Contributor

Hi,

haven't yet had the time to investigate this properly, but will give it a shot for sure.

Marco

@AdmiralenOla
Copy link
Owner Author

Ok, I've made it a little bit further. It seems that the main problem is that by default in python3, normal division of integers (using /) gives a float instead of an integer. This messes with the quadtree building. I'm changing the operator from / to // now. (This is also compatible with python 2.7)

@mgalardini
Copy link
Contributor

Awesome!

@AdmiralenOla
Copy link
Owner Author

However, the script still won't run because it seems the len function doesn't work with a zip object in python3! This causes the csv_to_dic method to fail. Will have to work my way around that!

@mgalardini
Copy link
Contributor

Ah, I see; let me know if I can be of any help on this

@AdmiralenOla
Copy link
Owner Author

Ok, fixed that by recasting some zip and dict_values objects into lists. Now checking if everything works...

@AdmiralenOla
Copy link
Owner Author

As far as I can tell, everything seems to be working in python3 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants