Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multifield is not working for the AEM 6.3 Coral UI 3-based Dialog fields #1013

Closed
acheson0410 opened this issue May 24, 2017 · 9 comments

Comments

@acheson0410
Copy link

@acheson0410 acheson0410 commented May 24, 2017

Hi,

The html markup & classes of Coral UI 3-based dialog fields have been updated in AEM 6.3. Therefore the ACS Touch UI Multi Field might not work as it will not able to find the field to set widget value.

Can we please have another version of ACS.TouchUI.NodeCompositeMultiField, ACS.TouchUI.CompositeMultiField & ACS.TouchUI.Widget, so it is compatible with the Coral UI 3-based dialog fields?

Thanks,
Johnny Yang

@stale

This comment has been minimized.

Copy link

@stale stale bot commented Sep 27, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot closed this Oct 4, 2017
@mzgubin

This comment has been minimized.

Copy link

@mzgubin mzgubin commented Aug 14, 2018

Could this issue be re-opened? We have been working on upgrading to AEM 6.4 and Adobe is recommending to change to Coral 3 but we cannot because we use this Multi-field component.

@davidjgonzalez

This comment has been minimized.

Copy link
Contributor

@davidjgonzalez davidjgonzalez commented Aug 14, 2018

@mzgubin This widget has caused us a great deal of pain over the years (many bugs/issues/time) - it would be most prudent to move to the Adobe supported multi-field [1] given that you are in the midst of a large upgrade project already (from the sounds of it) - Generally, we also don't want to encourage or grow its use.

Is it not possible/the cost very high to move over to the GraniteUI version? How come? (dialog configs or content serialization? Thinking if we could create a util or something to transform)?

If we were to re-open this, would you be planning on updating and supporting it moving forward? (Im not sure there is alot of appetite out there to do this work).

I don't mean to be rude ;) -- but this particular feature has been a thorn; i've never tallied up, but i expect it tops the "reported bugs" in the issues.

[1] https://helpx.adobe.com/experience-manager/6-3/sites/developing/using/reference-materials/granite-ui/api/jcr_root/libs/granite/ui/components/coral/foundation/form/multifield/index.html

@Ronald-Diemicke

This comment has been minimized.

Copy link

@Ronald-Diemicke Ronald-Diemicke commented Aug 29, 2018

@davidjgonzalez - It seems like this would be the perfect opportunity for someone to create a 'one-time' run script to convert the ACS commons multifield into the granite multifield.

Does anyone have an example of the differences? I'm somewhat running under the assumption that the granite multifield no longer uses JSON to store data, is that correct?

@davidjgonzalez

This comment has been minimized.

Copy link
Contributor

@davidjgonzalez davidjgonzalez commented Aug 29, 2018

.. and to be clear this would be a script that changes the CONTENT structures (across author and pubs somehow), and the dialog nodes would have to be changed by developers, and deployed.

There is the concern (which I don’t think we can automate) in updating consuming code to match new structures - esp if you were using JSON before, and now moves to composite nodes.

@Ronald-Diemicke

This comment has been minimized.

Copy link

@Ronald-Diemicke Ronald-Diemicke commented Aug 30, 2018

Agreed. Maybe documentation on common ways to handle this is a better use of time to help people upgrade their own things rather than trying to make a one size fits all tool... just a thought.

@felipeabellan

This comment has been minimized.

Copy link

@felipeabellan felipeabellan commented Mar 14, 2019

Still struggling with this in 2019. Coral 3 multifield work with coral-template which doesnt seem to be accessible to the 'selectors in JS. Another difference is that when nested multifield.js is fired, Coral 2 has already all the necessary structure (i.e the correct number of items added beforehand). Coral 3 not so much.

@davidjgonzalez

This comment has been minimized.

Copy link
Contributor

@davidjgonzalez davidjgonzalez commented Mar 14, 2019

@felipeabellan are you commenting on the OOTB AEM Multifields, or on the ACS COmmons multifield?
Ideally, you aren't using the ACS Commons multfield, but instead the OOTB multfields, and logging any potential issues you find w/ the OOTB one w/ Adobe support.

@felipeabellan

This comment has been minimized.

Copy link

@felipeabellan felipeabellan commented Mar 14, 2019

ACS Commons Mulifield looking to migrate to OOB coral 3 multifield. So really not an issue with Adobe's. I'm using json store because project comes from way back EXTJS multifield would save composite fields as json, so ACS commons was a good bandaid for a while, until coral3 migration came along. So what I'm looking for is a possible migration JS from ACS commons coral 2 JSON store to OOB multifield coral 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.