Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Review: AEM Dialog Editor #1983

Closed
ahmed-musallam opened this issue Jul 9, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@ahmed-musallam
Copy link
Contributor

commented Jul 9, 2019

I've built this: https://blogs.perficientdigital.com/2019/07/08/aem-dialog-editor/
And here is the repo for it, with initial code that most likely needs refactoring: https://github.com/ahmed-musallam/AEM-Dialog-Editor

I'd love to contribute it to ACS Commons, or Maybe ACS tools?

Please take a look and let me know if there is anything that I need to change to contribute it.

@davidjgonzalez

This comment has been minimized.

Copy link
Contributor

commented Jul 10, 2019

This looks awesome !!! ... I think ACS Tools would be a better candidate since this is squarely a dev tool. That said, ACS Tools seems to not be as well used (I assume because its "yet another package to install"). I'd be curious if, as time has passed, folks have thoughts of if/how the consolidation of the projects could be done appropriately.

Certainly nothing immediate (and I haven't looked at the code yet :)) .. but it'd be cool if this could be pulled into the IDE (for example, a few months ago I made an Intellij frontend for AEM Fiddle).

@kwin

This comment has been minimized.

Copy link
Contributor

commented Jul 10, 2019

Looks really nice, but definitely belongs to ACS Tools. Such tools should not be installed on production servers.

@ahmed-musallam

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

good points! I'm closing this and will make a contribution to ACS tools.

@davidjgonzalez I agree! pulling this into IDE would be perfect! the source of truth becomes the source-code, instead of it being the JCR. Any pointers on designing this so that it is IDE plugin friendly ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.