Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hostnames to allowlist #200

Merged
merged 2 commits into from Jul 25, 2022
Merged

Added hostnames to allowlist #200

merged 2 commits into from Jul 25, 2022

Conversation

adityaganotra
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@adityaganotra
Copy link
Contributor Author

Screenshot 2022-07-19 at 12 48 54 PM

Screenshot 2022-07-19 at 12 49 14 PM

Screenshot 2022-07-19 at 12 49 26 PM

6593-5366-49fc-aea6-ce8f155b7dc1.png">

@@ -71,6 +71,12 @@ To get started with PDF Services SDK, refer [Quickstarts](../pdf-services-api).

<br/>

<InlineAlert slots="text"/>

Please allow-list the following hostnames before using Adobe PDF Services SDK :<ul><li>ims-na1.adobelogin.com</li><li>cpf-ue1.adobe.io</li><li>senseicore-ue1.adobe.io (for versions below 1.x.x)</li></ul>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove space before colon after SDK

@@ -20,6 +20,10 @@ During the credential creation process you'll be asked to whether you'd like a *

PDF Accessibility Auto-Tag API is available as SDKs in Java and Python.

<InlineAlert slots="text"/>

Please allow-list the following hostnames before using Adobe PDF Services SDK :<ul><li>ims-na1.adobelogin.com</li><li>cpf-ue1.adobe.io</li><li>senseicore-ue1.adobe.io (for versions below 1.x.x)</li></ul>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above comment, remove space

@@ -23,6 +23,10 @@ During the credential creation process you'll be asked to whether you'd like a *

PDF Services API is also accessible via SDKs in popular languages such as Node.js, Java , .NET and Python.

<InlineAlert slots="text"/>

Please allow-list the following hostnames before using Adobe PDF Services SDK :<ul><li>ims-na1.adobelogin.com</li><li>cpf-ue1.adobe.io</li><li>senseicore-ue1.adobe.io (for versions below 1.x.x)</li></ul>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto above comments :)

@@ -24,6 +24,10 @@ During the credential creation process you'll be asked to whether you'd like a *

PDF Services API is also accessible via SDKs in popular languages such as Node.js, Java and .NET.

<InlineAlert slots="text"/>

Please allow-list the following hostnames before using Adobe PDF Services SDK :<ul><li>ims-na1.adobelogin.com</li><li>cpf-ue1.adobe.io</li><li>senseicore-ue1.adobe.io (for versions below 1.x.x)</li></ul>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto above

@adityaganotra adityaganotra merged commit 5312fc8 into main Jul 25, 2022
@adityaganotra adityaganotra deleted the add_hostname branch September 5, 2022 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants