Skip to content
This repository

A repo to push patches to for reviewing

branch: master
README.md

PatchReview

Git directory for reviewing warnings fix patches in the openjdk.

Process

  1. Fork the main repository (AdoptOpenJDK/PatchReview)
  2. Patches to be reviewed should be committed to the unreviewed directory.
  3. Review a patch, following the guidelines at http://java.net/projects/jugs/pages/AdoptOpenJDK/
  4. Feel free to make trivial changes if that helps get the patch through (although still note down the author of the patch to tell them what you changed and why).
  5. If approved, move the reviewed patch to the reviewed directory
  6. If the patch has already been applied to the OpenJDK codebase by someone else, move it to the beaten directory
  7. If the patch is inappropriate for some reason, move it to the rejected directory with a comment as to why you rejected the patch.
  8. Commit, writing a comment in the git commit message, comment should either be "Approved" or "2nd opinion requested".
  9. If you need a second review on a patch then put it in the 'further_review_needed' directory
  10. Rinse and repeat per patch (you can group patch reviews in a single commit, but make sure that this is grouped sensibly, try to to mix rejected with approved etc)
  11. Submit a pull request so that someone else can double check your work
Something went wrong with that request. Please try again.