From 9433761419851bac20786023a2754e557a9c0b0a Mon Sep 17 00:00:00 2001 From: George Adams Date: Thu, 9 Apr 2020 10:16:26 +0100 Subject: [PATCH 1/2] add more bad tests for better coverage --- .../adoptopenjdk/api/DownloadStatsPathTest.kt | 22 +++++++++++++++++++ .../net/adoptopenjdk/api/VersionPathTest.kt | 20 +++++++++++++++++ 2 files changed, 42 insertions(+) diff --git a/adoptopenjdk-api-v3-frontend/src/test/kotlin/net/adoptopenjdk/api/DownloadStatsPathTest.kt b/adoptopenjdk-api-v3-frontend/src/test/kotlin/net/adoptopenjdk/api/DownloadStatsPathTest.kt index eb9a7a0f..0bb240cf 100644 --- a/adoptopenjdk-api-v3-frontend/src/test/kotlin/net/adoptopenjdk/api/DownloadStatsPathTest.kt +++ b/adoptopenjdk-api-v3-frontend/src/test/kotlin/net/adoptopenjdk/api/DownloadStatsPathTest.kt @@ -150,6 +150,17 @@ class DownloadStatsPathTest : BaseTest() { } } + @Test + fun badTotalVersionReturnsSaneData() { + runBlocking { + RestAssured.given() + .`when`() + .get("/v3/stats/downloads/total/101") + .then() + .statusCode(400) + } + } + @Test fun totalTagReturnsSaneData() { runBlocking { @@ -171,6 +182,17 @@ class DownloadStatsPathTest : BaseTest() { } } + @Test + fun badTotalTagReturnsSaneData() { + runBlocking { + RestAssured.given() + .`when`() + .get("/v3/stats/downloads/total/101/fooBar") + .then() + .statusCode(400) + } + } + @Test fun trackingReturnsSaneData() { runBlocking { diff --git a/adoptopenjdk-api-v3-frontend/src/test/kotlin/net/adoptopenjdk/api/VersionPathTest.kt b/adoptopenjdk-api-v3-frontend/src/test/kotlin/net/adoptopenjdk/api/VersionPathTest.kt index 6dcf73ad..de675eb1 100644 --- a/adoptopenjdk-api-v3-frontend/src/test/kotlin/net/adoptopenjdk/api/VersionPathTest.kt +++ b/adoptopenjdk-api-v3-frontend/src/test/kotlin/net/adoptopenjdk/api/VersionPathTest.kt @@ -38,4 +38,24 @@ class VersionPathTest { .statusCode(200) .body(VersionDataMatcher(parsed)) } + + @Test + fun parsesNoVersion() { + + RestAssured.given() + .`when`() + .get("/v3/version/") + .then() + .statusCode(404) + } + + @Test + fun parsesBadVersion() { + + RestAssured.given() + .`when`() + .get("/v3/version/fooBar") + .then() + .statusCode(400) + } } From 64f1c4f3d53f56c1e41fed53d2fc55fd081cb4be Mon Sep 17 00:00:00 2001 From: George Adams Date: Thu, 9 Apr 2020 10:19:27 +0100 Subject: [PATCH 2/2] fix linter failure --- .../src/test/kotlin/net/adoptopenjdk/api/VersionPathTest.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/adoptopenjdk-api-v3-frontend/src/test/kotlin/net/adoptopenjdk/api/VersionPathTest.kt b/adoptopenjdk-api-v3-frontend/src/test/kotlin/net/adoptopenjdk/api/VersionPathTest.kt index de675eb1..9145e1de 100644 --- a/adoptopenjdk-api-v3-frontend/src/test/kotlin/net/adoptopenjdk/api/VersionPathTest.kt +++ b/adoptopenjdk-api-v3-frontend/src/test/kotlin/net/adoptopenjdk/api/VersionPathTest.kt @@ -38,7 +38,7 @@ class VersionPathTest { .statusCode(200) .body(VersionDataMatcher(parsed)) } - + @Test fun parsesNoVersion() {