Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Protobuf configure options #883

Open
wants to merge 1 commit into
base: master
from

Conversation

@cwesMills
Copy link
Contributor

commented Aug 6, 2019

Changed configure options for Protobuf to make Protobuf more optimized.

Signed-off-by: Colton Mills millscolt3@gmail.com

@sxa555

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

Presumably since we're removing the building of the shared library this is statically linked in. Have we done much testing to ensure this won't have any breaking changes. Post-merging it'll also need to be rebuilt on all the affected machines before this can take effect (The playbooks won't know to do that automatically)

@sxa555 sxa555 added the enhancement label Aug 7, 2019

@cwesMills

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2019

@dmitry-ten could you please answer the above question.

@karianna karianna added this to TODO in openjdk-infrastructure via automation Aug 7, 2019

@karianna karianna added this to the August 2019 milestone Aug 7, 2019

@karianna karianna moved this from TODO to QA / Review in openjdk-infrastructure Aug 7, 2019

Changed Protobuf configure options
Changed configure options for Protobuf to make Protobuf more optimized.

Signed-off-by: Colton Mills <millscolt3@gmail.com>

@cwesMills cwesMills force-pushed the cwesMills:protobuf_update_config branch from b7d5388 to 1ad8718 Aug 8, 2019

@cwesMills cwesMills changed the title Changed Protobuf configure options WIP: Changed Protobuf configure options Aug 16, 2019

@cwesMills cwesMills changed the title WIP: Changed Protobuf configure options Changed Protobuf configure options Aug 20, 2019

@sxa555

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

@dmitry-ten

This comment has been minimized.

Copy link

commented Aug 22, 2019

Sorry, haven't seen this PR before. I thought the previous ping referred to a different PR.
We've been running all tests with statically linked protobuf for a while now, haven't seen anything break. I thought protobuf on all affected machines was already rebuilt.

@karianna

This comment has been minimized.

Copy link
Member

commented Aug 24, 2019

Sorry, haven't seen this PR before. I thought the previous ping referred to a different PR.
We've been running all tests with statically linked protobuf for a while now, haven't seen anything break. I thought protobuf on all affected machines was already rebuilt.

I suggest that we land this when @dmitry-ten is online to help support if things break :-)

What day/time suits?

@dmitry-ten

This comment has been minimized.

Copy link

commented Aug 24, 2019

Tuesday-Friday morning EST should be fine, just ping me when this happens.
Actually, since you seem to be in UK, morning uk time should also work, since I'm in Moscow rn.

@karianna

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

Tuesday-Friday morning EST should be fine, just ping me when this happens.
Actually, since you seem to be in UK, morning uk time should also work, since I'm in Moscow rn.

Sorry to reply to this so late. Are you on our adoptopenjdk.net/slack.html slack? it'll be easier to co-ordinate a time there.

@dmitry-ten

This comment has been minimized.

Copy link

commented Aug 29, 2019

Yes, I am on that slack channel.

@karianna karianna modified the milestones: August 2019, September 2019 Sep 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.