Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the ability to repeat payloads for the sessions workload #1245

Merged
merged 2 commits into from Aug 24, 2019

Conversation

@cedrichansen
Copy link
Contributor

commented Aug 2, 2019

  • Payloads can be repeated by using the repetitionDelay keyword in xml configuration files
  • View change in README for documentation on the change
  • view config/config_repetitionDelayExample.xml for an example configuration file

Signed-off-by: Cedric Hansen cedric.hansen@ibm.com

@karianna karianna added this to the August 2019 milestone Aug 7, 2019

@karianna karianna added this to TODO in openjdk-test via automation Aug 7, 2019

@karianna karianna added the enhancement label Aug 7, 2019

@karianna karianna moved this from TODO to In Progress in openjdk-test Aug 7, 2019

Adding the ability to repeat payloads for the sessions workload
- Payloads can be repeated by using the `repetitionDelay` keyword
- View change in README for documentation
- view config/config_repetitionDelayExample.xml for an example configuration file

Signed-off-by: Cedric Hansen <cedric.hansen@ibm.com>

@cedrichansen cedrichansen marked this pull request as ready for review Aug 20, 2019

@cedrichansen

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2019

Tested the changes locally with the SyntheticGCWorkload jar and the example configuration files (config_repetitionDelayExample.xml), and the behaviour is the same as previously observed in my standalone copy of SGCW (ie, is working as expected). @smlambert These changes are ready for review

@smlambert
Copy link
Contributor

left a comment

Based on our desk-side review/discussion, and pending the minor updates based on my review comments, I will merge this and request a post-merge review from @amicic upon his return.

Fixed a few spelling mistakes from PR review.
Signed-off-by: Cedric Hansen <cedric.hansen@ibm.com>

@karianna karianna merged commit 5eb3076 into AdoptOpenJDK:master Aug 24, 2019

openjdk-test automation moved this from In Progress to Done Aug 24, 2019

smlambert added a commit that referenced this pull request Sep 4, 2019
Adding some additional documentation for SyntheticGCWorkload (#1321)
* Adding some additional documentation for SyntheticGCWorkload

- Changes in Readme to reflect the addition of a few keywords in change: #1245

Signed-off-by: Cedric Hansen <cedric.hansen@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.