Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide informative title for each of the routes and sub-routes #22

Closed
yochannah opened this Issue May 30, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@yochannah
Copy link
Collaborator

yochannah commented May 30, 2018

The filters for protein & genes at the top is great, but it's a little hard to tell which page you're on at any given time. Could we add a title, to the page? Perhaps something like "[datatype] in [minename]" e.g. "Proteins in HumanMine", "Genes in KittenMine" or something more generic for the landing page - perhaps "popular data types in HumanMine"

@yochannah

This comment has been minimized.

Copy link
Collaborator Author

yochannah commented May 30, 2018

when the genes / proteins filters are active up top they probably ought to be highlighted in some way - possibly by having a checkmark next to the active one and/or having the filters be white when not selected and coloured when they are (this can be tricky with only two as it's hard to tell which is highlighted and which isn't, which is why I suggest the checkmark as well).

AdrianBZG added a commit that referenced this issue May 31, 2018

AdrianBZG added a commit that referenced this issue May 31, 2018

@AdrianBZG

This comment has been minimized.

Copy link
Owner

AdrianBZG commented May 31, 2018

Closed by 3d863ab and 218f0c6 👍

@AdrianBZG AdrianBZG closed this May 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.