Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to add their API tokens for each mine #69

Closed
yochannah opened this issue Jul 30, 2018 · 7 comments

Comments

@yochannah
Copy link
Collaborator

commented Jul 30, 2018

In order to save lists, users ought to be able to save their personal API tokens to the data browser. I'd suggest a "sign in" button on the top right that allows the user to paste their token in, making it very clear that they need to paste in once per mine.

something like:

blank diagram - page 1 1

Save API keys in localstorage; I don't think we want to create a login infrastructure for this right now.

@AdrianBZG

This comment has been minimized.

Copy link
Owner

commented Sep 9, 2018

@AdrianBZG AdrianBZG closed this Sep 9, 2018

@yochannah

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 10, 2018

Looks briliant, and I love the guidance text here! (pausing for a moment as I just realised I like it because I wrote it in the mock up the top of this issue 🤣)

A few things: I might the "Paste your API key here" be a placeholder. This means the user doesn't have to delete the text.

see screenshots:

placeholder rather than value:
image

What it looks like (the top text in grey disappears when the user types)

image

it might also be nice to make the page less whitespacey when it's on a small screen.

I also tried to save a list after entering my flymine token and nothing happened - I couldn't see the list on flymine. Maybe I did something wrong?

@AdrianBZG AdrianBZG reopened this Sep 10, 2018

@AdrianBZG

This comment has been minimized.

Copy link
Owner

commented Sep 10, 2018

@yochannah Oh, I will take a look and fix that in a moment, also will change it from value to placeholder. About the whitespacey thing, I don't know really know how to have it properly while maintaining the float-md-left and float-md-right of the elements (text + input) to keep them aligned, since once I do that, I need to add extra < br > to avoid overlapping, I will see if there is some other workaround.

@yochannah

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 10, 2018

@AdrianBZG

This comment has been minimized.

Copy link
Owner

commented Sep 10, 2018

@yochannah Sure! I'll try with flexbox today and tell you if I don't manage to get it properly so you can enlighten me tomorrow 👍

AdrianBZG added a commit that referenced this issue Sep 10, 2018
AdrianBZG added a commit that referenced this issue Sep 10, 2018
@AdrianBZG

This comment has been minimized.

Copy link
Owner

commented Sep 10, 2018

@yochannah Done 😄 It works like a charm with flexbox, thanks. Also now uses the API key provided by the user to load the table, I've tested it with a public one:

image

http://im-browser-prototype.herokuapp.com/

If you can confirm that it works, the issue can be closed.

@yochannah

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 11, 2018

Looks good!

I tried pasting a bad key and the "save as list" button disappears. I'm guessing this might be imtables being intelligent since there are a bunch of console errors where imtables is getting upset :) anyway, disappearing the button with a bad key is good.

I have a few small improvements to suggest, but they're non-urgent - I'll make them tickets on the main intermine repo.

@yochannah yochannah closed this Sep 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.