Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read 05AB1E-encoded files as raw bytes, not UTF-8 #84

Merged
merged 1 commit into from Jun 16, 2017

Conversation

Projects
None yet
2 participants
@tckmn
Copy link
Contributor

commented Jun 16, 2017

When the -c/--osabie flag was passed, the interpreter was previously
reading the input file as UTF-8 anyway. Since the 05AB1E codepage
contains bytes that are invalid UTF-8, this fails for many programs.

Instead, it should read the file in binary mode rather than interpreting
what should be raw bytes under any kind of encoding.

Read 05AB1E-encoded files as raw bytes, not UTF-8
When the -c/--osabie flag was passed, the interpreter was previously
reading the input file as UTF-8 anyway. Since the 05AB1E codepage
contains bytes that are invalid UTF-8, this fails for many programs.

Instead, it should read the file in binary mode rather than interpreting
what should be raw bytes under any kind of encoding.

@Adriandmen Adriandmen merged commit 4463b8b into Adriandmen:master Jun 16, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.