Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log doesn't uses "String.Format" #33

Open
negue opened this issue Oct 6, 2014 · 3 comments
Open

Log doesn't uses "String.Format" #33

negue opened this issue Oct 6, 2014 · 3 comments
Labels

Comments

@negue
Copy link

negue commented Oct 6, 2014

This is what I get from AdRotatorControl.Log => "Control {0} - Trying provider AdDuplex", where is the {0} Parameter? :)

@SimonDarksideJ
Copy link
Contributor

:D.

It is using string.format.

Basically the number relates to the instance of AdRotator that is being logged. It isn't a parameter, it's just a wrapped number.

Might change the {} to [ ] instead so it's a bit clearer.

If you use more than one AdRotator control (and you can also specify the instance number on initialisation) then you can get specific reporting on each control through the one Log event.

@negue
Copy link
Author

negue commented Oct 7, 2014

Oh, I see xD.

So I could only set the number if I would create the AdRotatorControl in the codebehind but not in the XAML-Created one?

@SimonDarksideJ
Copy link
Contributor

If you don't set one, AdRotator will set one for you.
However your point about assigning a code in XAML is an interesting one, will have to investigate how to do that, probably through another property.
But yes, currently assigning the ID is only available in code behind as that is where the request came from

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants