From 82f0872b938f1cc0c659d87bbcdf611d1debbaf2 Mon Sep 17 00:00:00 2001 From: Ryan Govostes Date: Mon, 27 Jul 2020 03:10:15 -0400 Subject: [PATCH] Remove redundant exception traceback (#102) `log.exception` already includes a traceback, so don't add another. --- umodbus/server/__init__.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/umodbus/server/__init__.py b/umodbus/server/__init__.py index cf496e8..03b598b 100644 --- a/umodbus/server/__init__.py +++ b/umodbus/server/__init__.py @@ -48,9 +48,7 @@ def handle(self): response_adu = self.process(mbap_header + request_pdu) self.respond(response_adu) except: - import traceback - log.exception('Error while handling request: {0}.' - .format(traceback.print_exc())) + log.exception('Error while handling request') raise def process(self, request_adu): @@ -91,8 +89,8 @@ def execute_route(self, meta_data, request_pdu): except ModbusError as e: function_code = get_function_code_from_request_pdu(request_pdu) return pack_exception_pdu(function_code, e.error_code) - except Exception as e: - log.exception('Could not handle request: {0}.'.format(e)) + except Exception: + log.exception('Could not handle request') function_code = get_function_code_from_request_pdu(request_pdu) return pack_exception_pdu(function_code,