From a576b70b6e4c246977ce98e96d54c1244454e11b Mon Sep 17 00:00:00 2001 From: rajni Date: Thu, 6 Sep 2018 17:22:01 +0200 Subject: [PATCH 1/2] Added a new setter method to set PaymentDetailRequest properties. --- .../com/adyen/model/checkout/PaymentsDetailsRequest.java | 9 +++++++++ src/test/java/com/adyen/CheckoutTest.java | 5 +---- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/src/main/java/com/adyen/model/checkout/PaymentsDetailsRequest.java b/src/main/java/com/adyen/model/checkout/PaymentsDetailsRequest.java index 61fd3466e..da7cdb713 100755 --- a/src/main/java/com/adyen/model/checkout/PaymentsDetailsRequest.java +++ b/src/main/java/com/adyen/model/checkout/PaymentsDetailsRequest.java @@ -23,6 +23,7 @@ import com.google.gson.annotations.SerializedName; +import java.util.HashMap; import java.util.Map; import java.util.Objects; @@ -80,6 +81,14 @@ public void setPaymentData(String paymentData) { this.paymentData = paymentData; } + public PaymentsDetailsRequest set3DRequestData(String md, String paRes, String paymentData) { + HashMap details = new HashMap<>(); + details.put("MD", md); + details.put("PaRes", paRes); + this.details(details).paymentData(paymentData); + return this; + } + @Override public boolean equals(Object o) { if (this == o) { diff --git a/src/test/java/com/adyen/CheckoutTest.java b/src/test/java/com/adyen/CheckoutTest.java index c398d6de4..3b61bf51b 100644 --- a/src/test/java/com/adyen/CheckoutTest.java +++ b/src/test/java/com/adyen/CheckoutTest.java @@ -226,10 +226,7 @@ protected PaymentsRequest createPaymentsCheckoutRequest() { protected PaymentsDetailsRequest createPaymentsDetailsRequest() { PaymentsDetailsRequest paymentsDetailsRequest = new PaymentsDetailsRequest(); paymentsDetailsRequest.setPaymentData("Ab02b4c0!BQABAgCJN1wRZuGJmq8dMncmypvknj9s7l5Tj..."); - HashMap details = new HashMap<>(); - details.put("MD", "sdfsdfsdf..."); - details.put("PaRes", "sdfsdfsdf..."); - paymentsDetailsRequest.setDetails(details); + paymentsDetailsRequest.set3DRequestData("mdValue", "paResValue", "paymentDataValue"); return paymentsDetailsRequest; } From d8303083acdb4a9084ff4f615c0b2593721e0c0a Mon Sep 17 00:00:00 2001 From: rajni Date: Thu, 6 Sep 2018 18:20:05 +0200 Subject: [PATCH 2/2] added check for null details --- .../adyen/model/checkout/PaymentsDetailsRequest.java | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/main/java/com/adyen/model/checkout/PaymentsDetailsRequest.java b/src/main/java/com/adyen/model/checkout/PaymentsDetailsRequest.java index da7cdb713..f58e4986f 100755 --- a/src/main/java/com/adyen/model/checkout/PaymentsDetailsRequest.java +++ b/src/main/java/com/adyen/model/checkout/PaymentsDetailsRequest.java @@ -82,10 +82,14 @@ public void setPaymentData(String paymentData) { } public PaymentsDetailsRequest set3DRequestData(String md, String paRes, String paymentData) { - HashMap details = new HashMap<>(); - details.put("MD", md); - details.put("PaRes", paRes); - this.details(details).paymentData(paymentData); + if (this.details == null) { + this.details = new HashMap<>(); + } + + this.details.put("MD", md); + this.details.put("PaRes", paRes); + + this.paymentData(paymentData); return this; }