Skip to content

Conversation

@gcatanese
Copy link
Contributor

PR to generate the Legal Entity Management models.

All models have been updated to handle the nullable value (Mustache templates have been updated as part of #1603)

@gcatanese gcatanese requested review from a team as code owners December 8, 2025 13:49
@gcatanese gcatanese requested a review from galesky-a December 8, 2025 13:49
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @gcatanese, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates all generated Legal Entity Management (LEM) models to provide enhanced control over JSON serialization, specifically regarding nullable values. By introducing explicit flags and a custom serialization method, the models can now differentiate between unset fields and fields explicitly set to null, offering more granular control over API request payloads. This change aligns with previous template updates to improve data representation.

Highlights

  • Nullable Value Handling: Introduced explicit handling for nullable values in all Legal Entity Management (LEM) models, allowing for precise control over JSON serialization of null fields.
  • Serialization Flags: Added isSet<FieldName> boolean flags for each property in the models to track whether a field has been explicitly set by the user.
  • Explicit Null Serialization: Implemented a mechanism using @JsonAnyGetter and an includeNullValues flag to conditionally serialize null properties in the JSON payload, ensuring that nulls are only sent when intended.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a mechanism to handle nullable values in the Legal Entity Management models. The changes are consistent across all modified files, adding isSet... flags for each property and a new getExplicitNulls method to control JSON serialization of nulls. While the implementation is correct, it introduces a large amount of duplicated boilerplate code in each model class. My review includes a suggestion to refactor this into a common base class to improve maintainability.

@gcatanese gcatanese added the Enhancement Indicates new feature requests label Dec 8, 2025
@gcatanese gcatanese merged commit 78e41b3 into main Dec 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Indicates new feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants