PW-1999: added support for StoredValue API #359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aleffio
requested review from
AlexandrosMor,
andrei-dediu,
martinsrenato,
rikterbeek and
rkewlani
as code owners
Aleffio
changed the title
AlexandrosMor
previously approved these changes
Jun 9, 2020
AlexandrosMor
previously approved these changes
Jun 9, 2020
rkewlani
previously approved these changes
Jun 10, 2020
andrei-dediu
previously approved these changes
Jun 11, 2020
rikterbeek
reviewed
Jun 12, 2020
|
|
||
| storedValueStatusChangeRequest.setAmount(amount); | ||
| storedValueStatusChangeRequest.setMerchantAccount("merchantAccount"); | ||
| storedValueStatusChangeRequest.setPaymentMethod(new DefaultPaymentMethodDetails().type("givex").number("6036280000000000000").securityCode("1111")); |
There was a problem hiding this comment.
shall we introduce a givex payment method ? extending from a genericGiftCard payment method ?
…o DefaultPaymentMethodDetails, added tests for Issue and ChangeStatus
Aleffio
dismissed stale reviews from andrei-dediu, rkewlani, and AlexandrosMor
via
ea9905f
rikterbeek
approved these changes
Jun 15, 2020
rkewlani
approved these changes
Jun 15, 2020
andrei-dediu
approved these changes
Jun 15, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
added support for the following methods:
/issue
/changeStatus
/load
/checkBalance
/mergeBalance
/voidTransaction
Tested scenarios
e2e tests in progress
Fixed issue: