Skip to content

Conversation

@Aleffio
Copy link
Contributor

@Aleffio Aleffio commented Jun 23, 2020

Description
#358 Add webhooks event codes for additional configuration
#359 added support for StoredValue API
#360 added riskdata to checkout payments request
#361 add brand and networkPaymentReference fields to support Network Tokenization
#362 add idempotency key for instant payouts

Tested scenarios

Fixed issue:

Aleffio and others added 7 commits May 26, 2020 11:34
* PW-2080: Add webhooks event codes for additional configuration

* Update src/test/resources/mocks/notification/offer-closed.json
* PW-2378: added riskdata to checkout payments request

* PW-2378: fix comment

* PW-2378: remove systemout
#361)

* PW-2346: add brand and networkPaymentReference fields to support Network Tokenization, fixes #338

* PW-2346: use mc card for consistency
* PW-1999: added support for StoredValue API

* PW-1999: voidTransaction

* PW-1999: checkstyle changes only

* PW-1999: API_VERSION

* PW-1999: single class imports

* PW-1999: changed paymentMethod type in requests, added securitycode to DefaultPaymentMethodDetails, added tests for Issue and ChangeStatus

* PW-1999: added remaining unit tests

* PW-1999: fix comment
* Remove redundant local variable

* Remove unnecessary conversion

* lowercase packagename Util to util

* Replace null check with Objects.isNull

* - Create TextConstants class
- Replace "null" String value with TextConstants.NULL

* - Create TextConstants class
- Replace "null" String value with TextConstants.NULL

* Make use of Util.toIndentedString method
- replace duplicate code
- replace \n with constant

* static import Util.toIndentedString

* static import TextConstatnts.LINE_BREAK

* Assign new object to local variable

* Assign new object to local variable

* Revert Objects.isNull check

* Revert Objects.isNull check

* Enable the InnerAssignment checkstyle again

Co-authored-by: andrei-dediu <59608940+andrei-dediu@users.noreply.github.com>
@lgtm-com
Copy link

lgtm-com bot commented Jun 23, 2020

This pull request fixes 2 alerts when merging fe79acb into 95e480e - view on LGTM.com

fixed alerts:

  • 2 for Boxed variable is never null

@coveralls
Copy link

coveralls commented Jun 23, 2020

Coverage Status

Coverage increased (+0.9%) to 24.945% when pulling a5b2d44 on develop into 95e480e on master.

andrei-dediu
andrei-dediu previously approved these changes Jun 24, 2020
martinsrenato
martinsrenato previously approved these changes Jun 24, 2020
@Aleffio Aleffio dismissed stale reviews from martinsrenato and andrei-dediu via 7c2deb3 June 25, 2020 16:32
@lgtm-com
Copy link

lgtm-com bot commented Jun 25, 2020

This pull request fixes 2 alerts when merging 7c2deb3 into 95e480e - view on LGTM.com

fixed alerts:

  • 2 for Boxed variable is never null

@lgtm-com
Copy link

lgtm-com bot commented Jun 26, 2020

This pull request fixes 2 alerts when merging a5b2d44 into 95e480e - view on LGTM.com

fixed alerts:

  • 2 for Boxed variable is never null

@jonathanselander
Copy link

this unrelease is currently blocking a launch due to the "riskData" parameter missing issue, any speed here is greatly appreciated

@Aleffio Aleffio merged commit 758e1b3 into master Jun 26, 2020
@Aleffio
Copy link
Contributor Author

Aleffio commented Jun 26, 2020

Hi @jonathanselander ,

apologies for the delay,
the new version has been released,

Regards,
Alessio
Adyen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants