From b7fb703d410664d8556d723d90ed447c8c1d8ed1 Mon Sep 17 00:00:00 2001 From: Giorgos Adam Date: Thu, 3 May 2018 15:52:29 +0200 Subject: [PATCH] Implement ApiException.toString to become more verbose --- .../com/adyen/service/exception/ApiException.java | 7 ++++++- src/test/java/com/adyen/PaymentTest.java | 12 ++++++------ 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/src/main/java/com/adyen/service/exception/ApiException.java b/src/main/java/com/adyen/service/exception/ApiException.java index be2614380..a13a03bcb 100644 --- a/src/main/java/com/adyen/service/exception/ApiException.java +++ b/src/main/java/com/adyen/service/exception/ApiException.java @@ -1,4 +1,4 @@ -/** +/* * ###### * ###### * ############ ####( ###### #####. ###### ############ ############ @@ -52,4 +52,9 @@ public int getStatusCode() { public void setStatusCode(int statusCode) { this.statusCode = statusCode; } + + @Override + public String toString() { + return "ApiException{" + "error=" + error + ", statusCode=" + statusCode + ", message=" + getMessage() + '}'; + } } diff --git a/src/test/java/com/adyen/PaymentTest.java b/src/test/java/com/adyen/PaymentTest.java index 08f969bf5..aaf1b8223 100644 --- a/src/test/java/com/adyen/PaymentTest.java +++ b/src/test/java/com/adyen/PaymentTest.java @@ -43,6 +43,7 @@ import static org.junit.Assert.assertNotNull; import static org.junit.Assert.assertNull; import static org.junit.Assert.assertTrue; +import static org.junit.Assert.fail; import static org.mockito.ArgumentMatchers.any; import static org.mockito.Mockito.mock; import static org.mockito.Mockito.when; @@ -96,8 +97,8 @@ public void TestAuthoriseError010Mocked() throws Exception { PaymentRequest paymentRequest = createFullCardPaymentRequest(); try { - PaymentResult paymentResult = payment.authorise(paymentRequest); - assertTrue("Exception expected", false); + payment.authorise(paymentRequest); + fail("Exception expected"); } catch (ApiException e) { String errorCode = e.getError().getErrorCode(); assertEquals("010", errorCode); @@ -211,9 +212,10 @@ public void TestError401Mocked() throws Exception { PaymentRequest paymentRequest = createFullCardPaymentRequest(); try { - PaymentResult paymentResult = payment.authorise(paymentRequest); - assertTrue("Exception expected", false); + payment.authorise(paymentRequest); + fail("Exception expected"); } catch (ApiException e) { + assertTrue(e.toString().contains("401")); assertEquals(401, e.getStatusCode()); assertNull(e.getError()); } @@ -221,8 +223,6 @@ public void TestError401Mocked() throws Exception { /** * Test OpenInvoice API flow for klarna - * - * @throws Exception */ @Test public void TestOpenInvoice() throws Exception {