Skip to content
This repository has been archived by the owner on Aug 13, 2020. It is now read-only.

Juan mat sa ball #28

Merged
merged 15 commits into from Jan 17, 2016
Merged

Juan mat sa ball #28

merged 15 commits into from Jan 17, 2016

Conversation

JuanMatSa
Copy link
Member

Bueno, los test han pasado sin problemas =D

Por favor, toda sugerencia, consejo... todo, decídmelo, no os cortéis =D

Hay cosas tipo: meter rugosidad a la pelota (y ver el efecto de los agujeritos en la pelota de golf retrasando el desprendimiento), permitir otras distribuciones más realistas de resistencia aerodinámica [1] en lugar de una bola lisa... pero bueno, dado que no queremos hacer un simulador de balones, creí que con un modelo valdría.

Lo que a lo mejor si que es interesante es ampliarlo metiendo una función de momentos que dependería de la fricción... (ahora mismo nunca dejaría de girar, parecería el balón de Oliver y Bengi)

Un saludo!
[1] "Aerodynamic Drag of Contemporarty Soccer Balls" F.Alam et all, 19th Australasian Fluid Mechanic Conference

from pyfme.environment.isa import atm

# Constants
mu = 1.983 * 10 ** -5 # kg/m/s
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

es una tontería, pero a lo mejor 1.983e-5 queda mejor

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitivamente.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

creo que a mas de uno le han sangrado los ojos cuando ha visto * 10 ** -5

@AlexS12
Copy link
Member

AlexS12 commented Jan 10, 2016

Por mi parte todo lo que sea mejorar el modelo puede estar bien y mola. Pero podemos hacer el merge de la rama con el modelo que tenemos e ir haciendo mejoras más adelante.

Entre otras cosas recuerdo (y de esto ya te diste cuenta tú) que de momento nuestra pelota no puede girar locamente en cualquier dirección porque tenemos gimbal lock. Así que igual tiene más sentido incluir los cambios nuevos cuando tengamos cuaterniones.

@astrojuanlu
Copy link
Member

Cerrando y abriendo para que salte Travis CI.

@astrojuanlu astrojuanlu reopened this Jan 10, 2016
@astrojuanlu
Copy link
Member

Interesante: uno de los tests ha fallado en Python 2. ¿Por qué? 😉

@JuanMatSa
Copy link
Member Author

División entre un entero! ^^


References
----------
"Aerodynamics of Sports Balls" Bruce D. Jothmann, January 2007
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.. [1] "bla bla bla", Pepito ...

@JuanMatSa
Copy link
Member Author

Cualquier cosa que veáis, cualquier cosa que cambiaríais, por favor decidme.
En cuanto a contenido para revisión definitiva ya está @AlexS12 :)

r : float
radius(m)
S_circle : float
Surface (m^2)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

over-indented

@JuanMatSa
Copy link
Member Author

sabéis como meter una tabla en la documentación y que se vea adecuadamente?

@astrojuanlu
Copy link
Member

@JuanMatSa El lenguaje en el que se escribe la documentación se llama reStructuredText, y he encontrado un poco de información en español sobre tablas en http://code.nabla.net/es/rest.html#tablas

@JuanMatSa
Copy link
Member Author

gracie! @Juanlu001

@JuanMatSa
Copy link
Member Author

Good morning mates

I have addapted the code to the wiki symbols list. I think it is not really useful to add the ball symbols to the wiki (we are not going to analysis more balls... isn't it?)

I have just an issue: I have used TAS instead of U for the velocity... what do you think about?

I will have to add some symbols to the wiki (as I_array, C_D_vector_body... etc). However I think will not add the terms which are only used in a ball (Vol, radius... etc). What do you think?

If everything is ok, pull could be done :)


def check_sn(Sn):
"""Effective spin number must be between 0.00 and 0.40
Parameters
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line missing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line missing

AlexS12 added a commit that referenced this pull request Jan 17, 2016
Included ball with Magnus effects
@AlexS12 AlexS12 merged commit 3b72495 into AeroPython:master Jan 17, 2016
@AlexS12
Copy link
Member

AlexS12 commented Jan 17, 2016

habemus pelota!

@JuanMatSa JuanMatSa deleted the JuanMatSa_ball branch January 17, 2016 10:29
@astrojuanlu
Copy link
Member

🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants