Labeling Serial communication options #226

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
@eelsirhc
Contributor

eelsirhc commented May 25, 2012

Hi,

This group of changesets is an attempt to clear up the different options in the SerialCom.h file. The changeset adds comments to almost every case with a shorthand format to show what the expected input/ output format for each case (search for "format" in SerialCom.h ). ashima/AeroQuad@bee0199

In the few cases that a case option had multiple inconsistent output/inputs I altered the (usually dummy) section to read/write the same number of values with the same comma separated formatting. ashima/AeroQuad@66c9fbb

Chris.

eelsirhc added some commits May 18, 2012

Adding notes to each serial case
This changeset adds comments to outline the format expected from each of the serial send and receive commands. A few of the options seems inconsistent in this changeset but haven't been fixed (e.g. gps expects 9 data points if gps is enabled, but 6 if not).
Changing serial commands to make the various ifdef options more compa…
…rable.

A few of the serial commands (gps, mag) were not the same for the different IFDEF options available. This changeset attempts to make these different options more equal so that a programmatic interface to the configuration doesn't need to know as much about the internal configuration in order to read consisten output. Zeros are printed, or dummy values read, instead of the real values where necessary.
@Kenny9999

This comment has been minimized.

Show comment
Hide comment
@Kenny9999

Kenny9999 May 25, 2012

Member

Code document itself... no need of useless, pollution comment in that case,

Member

Kenny9999 commented May 25, 2012

Code document itself... no need of useless, pollution comment in that case,

@Kenny9999 Kenny9999 closed this May 25, 2012

@eelsirhc

This comment has been minimized.

Show comment
Hide comment
@eelsirhc

eelsirhc May 25, 2012

Contributor

The code is inconsistent depending on which hidden variables are defined, which the commenting allowed me to identify and fix.

Thanks,

Chris.

Contributor

eelsirhc commented May 25, 2012

The code is inconsistent depending on which hidden variables are defined, which the commenting allowed me to identify and fix.

Thanks,

Chris.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment