Skip to content

Feat: APA sentence#123

Merged
elpiel merged 18 commits intomainfrom
feat/apa-sentence
May 5, 2024
Merged

Feat: APA sentence#123
elpiel merged 18 commits intomainfrom
feat/apa-sentence

Conversation

@elpiel
Copy link
Member

@elpiel elpiel commented May 5, 2024

@ANG13T I did my best to merge the different commits from the 2 different branches and PRs that you opened.

I also had to fix 2 issues - 1 with serde and 1 with the Cargo.toml workspace members.
Feel free to take a look and raise any issue you find, I'll merge this once all checks pass.

PRs which this PR is based on: #119 #120

ANG13T and others added 16 commits January 31, 2024 08:03
Co-authored-by: Lachezar Lechev <8925621+elpiel@users.noreply.github.com>
Co-authored-by: Lachezar Lechev <8925621+elpiel@users.noreply.github.com>
Co-authored-by: Lachezar Lechev <8925621+elpiel@users.noreply.github.com>
Co-authored-by: Lachezar Lechev <8925621+elpiel@users.noreply.github.com>
Co-authored-by: Lachezar Lechev <8925621+elpiel@users.noreply.github.com>
Co-authored-by: Lachezar Lechev <8925621+elpiel@users.noreply.github.com>
@elpiel elpiel changed the title Feat/apa sentence Feat: APA sentence May 5, 2024
elpiel added 2 commits May 5, 2024 10:05
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
@codecov
Copy link

codecov bot commented May 5, 2024

Codecov Report

Attention: Patch coverage is 85.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 77.96%. Comparing base (62763a5) to head (b337b7c).

Files Patch % Lines
src/sentences/apa.rs 85.96% 8 Missing ⚠️
src/parser.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
+ Coverage   77.62%   77.96%   +0.33%     
==========================================
  Files          34       35       +1     
  Lines        1247     1307      +60     
==========================================
+ Hits          968     1019      +51     
- Misses        279      288       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elpiel elpiel merged commit 2f9cf42 into main May 5, 2024
@elpiel elpiel deleted the feat/apa-sentence branch May 5, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants