Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.14 change "broke" Game.print_all() #49

Closed
credomane opened this issue Sep 24, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@credomane
Copy link
Contributor

commented Sep 24, 2016

Due to Game.print_all checking player.connected any mod that uses stdlib in their on_init or on_configuration_changed handlers will show player.connected as always false in single player only.

See https://forums.factorio.com/33208 for the full details.

@Afforess

This comment has been minimized.

Copy link
Owner

commented Sep 24, 2016

Fantastic. Not sure how to safely tell if the player can be used to print out a message then...

@credomane

This comment has been minimized.

Copy link
Contributor Author

commented Sep 25, 2016

My understanding from rseding91 is if you get an error when anything.valid == true then it is extremely likely a factorio bug.

So I did some experimenting. I can print to offline players without errors and they will actually see any messages sent to them while offline in their console/chat history when they return too. I can actually do anything I want to an offline player as if they were online. So it would seem to me that you and I both do more validation checking than "required" in Factorio. :P

@Afforess

This comment has been minimized.

Copy link
Owner

commented Sep 25, 2016

So it would seem to me that you and I both do more validation checking than "required" in Factorio.

Given inconsistency in the past, I always err on the side of safety.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.