Skip to content

bug: fix a crash with an invalid query following MODIFY QUERY #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
git-hulk merged 1 commit into from
Nov 20, 2025
Merged

bug: fix a crash with an invalid query following MODIFY QUERY #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion parser/parser_alter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,10 @@ func (p *Parser) parseAlterTableModify(pos Pos) (AlterTableClause, error) {
}, nil
case p.matchKeyword(KeywordQuery):
_ = p.lexer.consumeToken()
selectQuery, _ := p.parseSelectQuery(pos)
selectQuery, err := p.parseSelectQuery(pos)
if err != nil {
return nil, err
}
return &AlterTableModifyQuery{
ModifyPos: pos,
StatementEnd: selectQuery.End(),
Expand Down
1 change: 1 addition & 0 deletions parser/parser_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ func TestParser_InvalidSyntax(t *testing.T) {
"SELECT n FROM t ORDER BY n WITH FILL STALENESS", // STALENESS without value
"SELECT n FROM t ORDER BY n WITH FILL INTERPOLATE (x", // Missing closing paren
"SELECT n FROM t ORDER BY n WITH FILL INTERPOLATE x AS x + 1", // Missing parens around column list
"ALTER TABLE foo_mv MODIFY QUERY AS SELECT * FROM baz", // MODIFY QUERY followed by an invalid query
}
for _, sql := range invalidSQLs {
parser := NewParser(sql)
Expand Down