Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Bureau Veritas #126

Merged
merged 2 commits into from Apr 12, 2023
Merged

Export Bureau Veritas #126

merged 2 commits into from Apr 12, 2023

Conversation

thom4parisot
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Apr 11, 2023

Deploy Preview for cartobio-dev ready!

Name Link
🔨 Latest commit 3a080a9
🔍 Latest deploy log https://app.netlify.com/sites/cartobio-dev/deploys/643683d95bc63a0008101ce3
😎 Deploy Preview https://deploy-preview-126--cartobio-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@thom4parisot thom4parisot temporarily deployed to staging April 11, 2023 13:59 — with GitHub Actions Inactive
@@ -18,7 +18,7 @@
"node": "^18.0.0"
},
"dependencies": {
"@agencebio/rosetta-cultures": "^1.1.2",
"@agencebio/rosetta-cultures": "^1.2.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cf. ce commit pour comprendre d'où vient la correspondance CPF/Code Bureau Veritas

@thom4parisot thom4parisot temporarily deployed to staging April 11, 2023 14:02 — with GitHub Actions Inactive
@thom4parisot thom4parisot temporarily deployed to staging April 11, 2023 16:22 — with GitHub Actions Inactive
@thom4parisot thom4parisot marked this pull request as ready for review April 11, 2023 20:44
@thom4parisot thom4parisot temporarily deployed to staging April 12, 2023 10:11 — with GitHub Actions Inactive
@thom4parisot
Copy link
Member Author

@jillro je me permets de fusionner la PR avant vendredi ; tes retours et questions sont quand même bienvenues :-)

Ces bouts de code sont "fragiles", au sens où sans lancer l'appli y'a peu de chances de détecter qu'un truc casse (on le détectera avec Sentry, mais quand même). Ça vaudra le coup d'avoir une réflexion sur la testabilité des fichiers produits.

@thom4parisot thom4parisot merged commit d714080 into v2 Apr 12, 2023
6 checks passed
@thom4parisot thom4parisot deleted the thomas/export-bv branch April 12, 2023 10:15
sortFn: sortByDescendingKey
},
})

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pourquoi pas directement juste au dessus ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Très juste ! Pour éviter que le tri/regroupement par date (YYYY-MM-DD) soit proposé dans le tableau de parcelles.

image

La liste est constituée à partir des items énumarables. Je ne sais pas rendre un item non-énumérable en utilisant la syntaxe d'objet litéral en JS. D'où l'utilisation de Object.defineProperty().

T'aurais vu d'autres manières de procéder ?

@thom4parisot thom4parisot restored the thomas/export-bv branch May 8, 2023 18:39
@thom4parisot thom4parisot deleted the thomas/export-bv branch May 8, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants