Ne resize la carte que lorsque nécessaire #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maud Royer <hello@maudroyer.fr>
✅ Deploy Preview for cartobio-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
src/components/Map/MapContainer.vue
Outdated
| @@ -55,8 +55,14 @@ watch(() => props.style, () => { | |||
| map.value.triggerRepaint() | |||
| }, { deep: true }) | |||
|
|
|||
| useResizeObserver(mapContainer, () => { | |||
| map.value.resize() | |||
| useResizeObserver(mapContainer, (entries) => { | |||
There was a problem hiding this comment.
Je me demande si quand on place le useResizeObserver dans le map.once('load'), on aboutit au même résultat.
Ainsi, c'est un événement d'interface qui le déclenche plutôt qu'une observation permanente d'un effet de clic.
|
Alors au final, le Ce que je me raconte, c'est que le changement de "mode" (compact ou fullSize) qui devrait trigger le refresh. Y'a un peu une condition d'exécution — il faut que le clic aie eu lieu, que le composant se soit agrandi, et là on peut déclencher le redimensionnement. C'est pas immédiat au changement de valeur d'une propriété. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utiliser
requestAnimationFramedevrait régler les erreursResizeObserverLoop