Improvements made for inclusion on WordPress.com VIP #12

Merged
merged 5 commits into from Sep 17, 2012

Conversation

Projects
None yet
2 participants
Contributor

danielbachhuber commented Sep 17, 2012

First off, thanks for the well-written plugin! It definitely falls into the upper 10% percentile of plugins we see from the community.

One of our clients asked for this plugin to be included in our shared plugins directory, so I made a couple minor improvements hopefully to your satisfaction.

The last improvement I'd like seen is an upper bound to the get_posts() query. 'numberposts' => -1 is potentially dangerous if a user were to add thousands of links. How would you prefer to address this?

@chrisguitarguy chrisguitarguy added a commit that referenced this pull request Sep 17, 2012

@chrisguitarguy chrisguitarguy Merge pull request #12 from Automattic/vip-improvements
Improvements made for inclusion on WordPress.com VIP
5cb352f

@chrisguitarguy chrisguitarguy merged commit 5cb352f into AgencyPMG:master Sep 17, 2012

Owner

chrisguitarguy commented Sep 17, 2012

Awesome thanks!

As far as the upper bound, maybe that's best left up to a filter -- similar to how the blacklist max filter you incorporated works.

Contributor

danielbachhuber commented Sep 17, 2012

Cool, I'll add that when I have a moment. We might also have some output caching coming your way too.

@chrisguitarguy chrisguitarguy added a commit that referenced this pull request Sep 17, 2012

@chrisguitarguy chrisguitarguy Allow end users to restrict total links fetched
Introduce another filter to that allows end users to change the maximum
number of links fetched instead of just fetching all of them.

See #12
5f9f7d7
Owner

chrisguitarguy commented Sep 17, 2012

Already got it. Output caching sounds awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment