Skip to content

Updated dashboard#6

Closed
mmabrouk wants to merge 1 commit into
mainfrom
playground_ui
Closed

Updated dashboard#6
mmabrouk wants to merge 1 commit into
mainfrom
playground_ui

Conversation

@mmabrouk
Copy link
Copy Markdown
Member

@mmabrouk mmabrouk commented May 6, 2023

I played around with the dashboard a bit today to understand more how nextjs/react/frontend works.

Here is are the minor changes I have done:

Overall I got a bit feeling on how the whole things work.

I am not sure if what I have done is much useful. I think using tremor makes sense. Overall, the change is quite minimal in any case.

I suggest you try the code and look at the result and decide whether to merge the PR or not.

p.s. Sorry about the badly named commit, I was trying to break my changes into lots of commits but made it all into one by mistake

@mmabrouk mmabrouk requested a review from aakrem May 6, 2023 14:49
@aakrem
Copy link
Copy Markdown
Contributor

aakrem commented May 6, 2023

  • Nice that you spent some time discovering how it works
  • however, on my screen, it looks bad (I think you were testing on a large screen)
  • I am also not a fan of adding components that don't work at all.
  • It's Nice that you found a new library that offers already-built components, however, they are still in beta, and I am not sure how good this approach is.
  • Also the text feels for me bigger than a normal text, especially for the table.
  • I don't like the new design but that's something related to people's tastes :D so

Screenshot 2023-05-06 at 20 08 02

Screenshot 2023-05-06 at 20 07 49

@mmabrouk mmabrouk closed this May 14, 2023
@mmabrouk mmabrouk deleted the playground_ui branch July 6, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants